<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 14, 2015, at 1:34 PM, Igor Ignatyev <<a href="mailto:igor.ignatyev@oracle.com" class="">igor.ignatyev@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Chris,<div class=""><br class=""></div><div class="">Thanks for review. we will address your comment later as a fix for RFE(JDK-8139619) if you don’t mind.</div></div></div></blockquote><div><br class=""></div>Sure.</div><div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">Thanks,</div><div class="">- Igor </div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Oct 15, 2015, at 2:13 AM, Christian Thalinger <<a href="mailto:christian.thalinger@oracle.com" class="">christian.thalinger@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Oct 14, 2015, at 8:29 AM, Dmitrij Pochepko <<a href="mailto:dmitrij.pochepko@oracle.com" class="">dmitrij.pochepko@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
  
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type" class="">
  
  <div text="#000000" bgcolor="#FFFFFF" class="">
    Hi,<br class="">
    <br class="">
    an issue with 1st version was found: a getDeclaredMethod
    parameter(line 67) wasn't changed according to testFrame method
    signature change.<br class="">
    Now changed from Integer.class boolean.class<br class="">
    <br class="">
    Please take a look at 2nd version:
    <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dpochepk/8139438/webrev.02">http://cr.openjdk.java.net/~dpochepk/8139438/webrev.02</a><br class=""></div></div></blockquote><div class=""><br class=""></div><div class=""><pre style="background-color: rgb(238, 238, 238);" class=""><span class="new" style="color: blue;">+        int levels[] = CompilerUtils.getAvailableCompilationLevels();</span>
<span class="new" style="color: blue;">+        // we need compilation level 4 to use EscapeAnalysis</span>
<span class="new" style="color: blue;">+        if (levels.length < 1 || levels[levels.length - 1] != 4) {</span>
</pre><div class=""><span class="new" style="color: blue;"><br class=""></span></div></div>To be more robust against future changes of this WB method you should search the array for level 4 instead of assuming it’s in the last element.</div><div class=""><br class=""></div><div class="">Otherwise this looks good.</div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div text="#000000" bgcolor="#FFFFFF" class="">
    <br class="">
    Thanks,<br class="">
    Dmitrij<br class="">
    <br class="">
    <div class="moz-cite-prefix">On 13.10.2015 23:15, Dmitrij Pochepko
      wrote:<br class="">
    </div>
    <blockquote cite="mid:561D6645.7040300@oracle.com" type="cite" class="">
      <meta http-equiv="content-type" content="text/html; charset=utf-8" class="">
      Hi, <br class="">
      <br class="">
      please review a small fix for test:
      compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java
      <meta http-equiv="content-type" content="text/html; charset=utf-8" class="">
      <br class="">
      <br class="">
      Description:<br class="">
      <br class="">
      A test is changed to run testcases in separate VM launch instead
      of consecutive execution, which had wrong assumption about method
      compilation state in case of -XX:-TieredCompilation.<br class="">
      So, a boolean system property is added into test to control test
      execution logic externally.<br class="">
      I've also added minor code cleanup.<br class="">
      <br class="">
      webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Edpochepk/8139438/webrev.01/">http://cr.openjdk.java.net/~dpochepk/8139438/webrev.01/</a>
      <br class="">
      <br class="">
      Thanks, <br class="">
      Dmitrij </blockquote>
    <br class="">
  </div>

</div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></body></html>