<div dir="ltr"><span style="color:rgb(0,0,0);font-family:'DejaVu Sans','Bitstream Vera Sans','Luxi Sans',Verdana,Arial,Helvetica;font-size:12px;line-height:14.9333px">Thanks Aleksey!</span><div><span style="color:rgb(0,0,0);font-family:'DejaVu Sans','Bitstream Vera Sans','Luxi Sans',Verdana,Arial,Helvetica;font-size:12px;line-height:14.9333px"><br></span></div><div><span style="color:rgb(0,0,0);font-family:'DejaVu Sans','Bitstream Vera Sans','Luxi Sans',Verdana,Arial,Helvetica;font-size:12px;line-height:14.9333px">Can I have another review for this patch?</span></div><div><span style="color:rgb(0,0,0);font-family:'DejaVu Sans','Bitstream Vera Sans','Luxi Sans',Verdana,Arial,Helvetica;font-size:12px;line-height:14.9333px"><br></span></div><div><span style="color:rgb(0,0,0);font-family:'DejaVu Sans','Bitstream Vera Sans','Luxi Sans',Verdana,Arial,Helvetica;font-size:12px;line-height:14.9333px">Regards</span></div><div><span style="color:rgb(0,0,0);font-family:'DejaVu Sans','Bitstream Vera Sans','Luxi Sans',Verdana,Arial,Helvetica;font-size:12px;line-height:14.9333px">Hui¬†</span><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 24 February 2016 at 22:24, Aleksey Shipilev <span dir="ltr"><<a href="mailto:aleksey.shipilev@oracle.com" target="_blank">aleksey.shipilev@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 02/24/2016 04:02 PM, Hui Shi wrote:<br>
> Thanks Andrew! Your comment looks really better and performance doesn't<br>
> change when run JMHSample_97_ArrayEqual.java<br>
</span>> <<a href="http://cr.openjdk.java.net/%7Ehshi/8149733/webrev2/JMHSample_97_ArrayEqual.java" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/%7Ehshi/8149733/webrev2/JMHSample_97_ArrayEqual.java</a>> test.<br>
><br>
> latest webrev <a href="http://cr.openjdk.java.net/~hshi/8149733/webrev3/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~hshi/8149733/webrev3/</a><br>
> <<a href="http://cr.openjdk.java.net/%7Ehshi/8149733/webrev3/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/%7Ehshi/8149733/webrev3/</a>><br>
<br>
Good.<br>
<span class=""><br>
> Following is result with Aleksey's updated test case (-w 5 -wi 3 -i3 -r<br>
> 10), first 4 group are for base run with base string length 0, 8, 31,<br>
> 1024. Performance with patch doesn't show same improvement with early<br>
> test. Only small length string equal tests still show obvious improvement.<br>
<br>
</span>...and that's okay for refactoring.<br>
<br>
Cheers,<br>
-Aleksey<br>
<br>
<br>
</blockquote></div><br></div>