<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 10, 2016, at 11:03 AM, Christian Thalinger <<a href="mailto:christian.thalinger@oracle.com" class="">christian.thalinger@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><a href="https://bugs.openjdk.java.net/browse/JDK-8151664" class="">https://bugs.openjdk.java.net/browse/JDK-8151664</a><div class=""><br class=""></div><div class="">I will just push it since it was reviewed already.</div></div></div></blockquote><div><br class=""></div>Turns out there was a missing jtreg tag:</div><div><br class=""></div><div><div style="margin: 0px; font-size: 10px; line-height: normal; font-family: Monaco; color: rgb(52, 189, 38);" class=""> * <span style="font-variant-ligatures: no-common-ligatures; color: #d53bd3" class="">@requires</span> (os.simpleArch == "x64" | os.simpleArch == "sparcv9" | os.simpleArch == "aarch64")                                                       </div><div class=""><br class=""></div><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""><div style="" class=""><blockquote type="cite" class=""><div class="">On Mar 10, 2016, at 10:58 AM, Christian Thalinger <<a href="mailto:christian.thalinger@oracle.com" class="">christian.thalinger@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Damn.  I forgot to hg add the test:<div class=""><br class=""></div><div class=""><a href="http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/3a1f495e37b3" class="">http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/3a1f495e37b3</a></div><div class=""><br class=""></div><div class="">That’s why you should send exported changesets :-)<br class=""><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 7, 2016, at 3:20 PM, Christian Thalinger <<a href="mailto:christian.thalinger@oracle.com" class="">christian.thalinger@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class=""><blockquote type="cite" class="">On Mar 7, 2016, at 11:03 AM, Doug Simon <<a href="mailto:doug.simon@oracle.com" class="">doug.simon@oracle.com</a>> wrote:<br class=""><br class="">I changed the webrev to use HotSpotResolvedObjectTypeImpl instead of making a (new) VM call and also added the test provided in the bug report. <br class=""></blockquote><br class="">That’s much better than I expected.  Looks good.<br class=""><br class=""><blockquote type="cite" class=""><br class="">-Doug<br class=""><br class=""><blockquote type="cite" class="">On 07 Mar 2016, at 19:13, Christian Thalinger <<a href="mailto:christian.thalinger@oracle.com" class="">christian.thalinger@oracle.com</a>> wrote:<br class=""><br class=""><br class=""><blockquote type="cite" class="">On Mar 5, 2016, at 1:45 AM, Doug Simon <<a href="mailto:doug.simon@oracle.com" class="">doug.simon@oracle.com</a>> wrote:<br class=""><br class="">Please review this small change that makes HotSpotResolvedJavaFieldImpl.isStable() return the right value for HotSpotResolvedJavaFieldImpl objects created from java.lang.reflect.Field objects. The problem was that HotSpotResolvedJavaField objects created from reflection objects didn’t get the VM internal modifier flags:<br class=""><br class=""><a href="http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/file/0adf6c8c7223/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaAccessProvider.java#l117" class="">http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/file/0adf6c8c7223/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaAccessProvider.java#l117</a><br class=""><br class=""><br class=""><a href="https://bugs.openjdk.java.net/browse/JDK-8151266" class="">https://bugs.openjdk.java.net/browse/JDK-8151266</a><br class=""></blockquote><br class="">There is a test attached to the bug.  We should add it.<br class=""><br class=""><blockquote type="cite" class=""><a href="http://cr.openjdk.java.net/~dnsimon/8151266/" class="">http://cr.openjdk.java.net/~dnsimon/8151266/</a><br class=""><br class="">-Doug<br class=""></blockquote><br class=""></blockquote><br class=""></blockquote><br class=""></div></div></blockquote></div><br class=""></div></div></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></body></html>