<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 18, 2016, at 10:34 AM, Nils Eliasson <<a href="mailto:nils.eliasson@oracle.com" class="">nils.eliasson@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
  
    <meta content="text/html; charset=windows-1252" http-equiv="Content-Type" class="">
  
  <div bgcolor="#FFFFFF" text="#000000" class="">
    <br class="">
    <br class="">
    <div class="moz-cite-prefix">On 2016-03-18 18:30, Christian
      Thalinger wrote:<br class="">
    </div>
    <blockquote cite="mid:4FA61F17-FA74-4194-90ED-4602C50B2961@oracle.com" type="cite" class="">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252" class="">
      <br class="">
      <div class="">
        <blockquote type="cite" class="">
          <div class="">On Mar 18, 2016, at 5:02 AM, Nils Eliasson <<a moz-do-not-send="true" href="mailto:nils.eliasson@oracle.com" class=""></a><a class="moz-txt-link-abbreviated" href="mailto:nils.eliasson@oracle.com">nils.eliasson@oracle.com</a>>
            wrote:</div>
          <br class="Apple-interchange-newline">
          <div class="">
            <div class="">Hi,<br class="">
              <br class="">
              Please review this test fix.<br class="">
              <br class="">
              Summary:<br class="">
              This test tests the locking of the compilers - make sure
              no compiles can be completed while the lock is in place.
              When running with -XX:-TieredCompilation and
              -XX:CompileThreshold=100 we got a fairly long queue of
              compiles waiting, and when only C2 is available it can
              take longer to complete than the test wait time.<br class="">
              <br class="">
              Solution:<br class="">
              Only allow compile of the test method - make sure we have
              no contention on the compile queue. With only a single
              method in the queue we can also reduce the wait time.<br class="">
              <br class="">
              Testing:<br class="">
              Test run in failing configuration.<br class="">
              <br class="">
              Bug: <a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8152169" class="">https://bugs.openjdk.java.net/browse/JDK-8152169</a><br class="">
              Webrev: <a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Eneliasso/8152169/webrev.01/" class="">http://cr.openjdk.java.net/~neliasso/8152169/webrev.01/</a><br class="">
            </div>
          </div>
        </blockquote>
        <div class=""><br class="">
        </div>
        <pre style="background-color: rgb(238, 238, 238);" class=""><b class=""><font class="" color="blue">+</font><font class="" color="blue">             // Sleep a while and then make sure the compile is still waiting</font></b>
<font class="" color="blue"><b class="">+             try {</b></font>
<font class="" color="blue"><b class="">+                 Thread.sleep(5000);</b></font>
<font class="" color="blue"><b class="">+             } catch (Exception e) {</b></font>
<font class="" color="blue"><b class="">+                 System.out.println("Thread sleep interrupted");</b></font>
<font class="" color="blue"><b class="">+             }</b></font></pre>
        Should we propagate this exception instead of just issuing a
        warning on stdout?<br class="">
      </div>
    </blockquote>
    <br class="">
    Sure, that's better. There are no thread that can interrupt it at
    the moment, but better safe than sorry.<br class="">
    <br class="">
    Webrev: <a href="http://cr.openjdk.java.net/~neliasso/8152169/webrev.02/" class="">http://cr.openjdk.java.net/~neliasso/8152169/webrev.02/</a><br class=""></div></div></blockquote><div><br class=""></div>I was thinking making the method "throws Exception”.  Would be simpler.  main already does:</div><div><pre style="background-color: rgb(238, 238, 238);" class=""><font color="black" class="">      public static void main(String[] args) throws Exception {</font></pre></div><div><blockquote type="cite" class=""><div class=""><div bgcolor="#FFFFFF" text="#000000" class="">
    <br class="">
    Regards,<br class="">
    Nils<br class="">
    <blockquote cite="mid:4FA61F17-FA74-4194-90ED-4602C50B2961@oracle.com" type="cite" class="">
      <div class=""><br class="">
        <blockquote type="cite" class="">
          <div class="">
            <div class=""><br class="">
              Regards,<br class="">
              Nils<br class="">
            </div>
          </div>
        </blockquote>
      </div>
      <br class="">
    </blockquote>
    <br class="">
  </div>

</div></blockquote></div><br class=""></body></html>