<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Christian<br>
    <br>
    I have fixed "mx checkstyle" errors.<br>
    Then new webrev is: <a class="moz-txt-link-freetext"
      href="http://cr.openjdk.java.net/%7Ekshefov/8152344/webrev.03/">http://cr.openjdk.java.net/~kshefov/8152344/webrev.03/</a><br>
    <br>
    -Konstantin<br>
    <br>
    <div class="moz-cite-prefix">On 25.03.2016 03:00, Christian
      Thalinger wrote:<br>
    </div>
    <blockquote
      cite="mid:F80DEA2E-F0B3-4602-AE2B-D45FC958452C@oracle.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      <br class="">
      <div>
        <blockquote type="cite" class="">
          <div class="">On Mar 24, 2016, at 11:37 AM, Konstantin Shefov
            <<a moz-do-not-send="true"
              href="mailto:konstantin.shefov@oracle.com" class="">konstantin.shefov@oracle.com</a>>

            wrote:</div>
          <br class="Apple-interchange-newline">
          <div class="">
            <meta content="text/html; charset=utf-8"
              http-equiv="Content-Type" class="">
            <div bgcolor="#FFFFFF" text="#000000" class=""> Hi,
              Christian<br class="">
              <br class="">
              It seems my local ws has not built correctly after "hg
              tpull -u". I have cloned fresh WS, patched it and built it
              again.<br class="">
              Now "mx build --no-native" works with no errors.<br
                class="">
              Unit tests passed on Linux x64<br class="">
              Then I have done "mx ideinit" and opened project in
              IntelliJ Idea and reformatted all my files.<br class="">
              <br class="">
              Please look at the new version of the webrev: <a
                moz-do-not-send="true"
                href="http://cr.openjdk.java.net/%7Ekshefov/8152344/webrev.02/"
                class="">http://cr.openjdk.java.net/~kshefov/8152344/webrev.02/</a><br
                class="">
            </div>
          </div>
        </blockquote>
        <div><br class="">
        </div>
        Excellent.  A couple things…</div>
      <div><br class="">
      </div>
      <div>I get 5 compiler warnings:</div>
      <div><br class="">
      </div>
      <div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">/Users/cthaling/ws/jdk9/hs-comp/hotspot/test/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestHelper.java:474:

          warning: [rawtypes] found raw type: Class</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">    public static
          ResolvedJavaField getResolvedJavaField(Class clazz, String
          fieldName) {</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">                              
                                    ^</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">  missing type arguments for
          generic class Class<T></div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">  where T is a type-variable:</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">    T extends Object declared
          in class Class</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">/Users/cthaling/ws/jdk9/hs-comp/hotspot/test/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/BoxPrimitiveDataProvider.java:48:

          warning: [cast] redundant cast to byte</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">            cfgSet.add(new
          Object[]{JavaConstant.forByte((byte) number),</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">                              
                                    ^</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">/Users/cthaling/ws/jdk9/hs-comp/hotspot/test/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/ReadConstantArrayElementDataProvider.java:234:

          warning: [rawtypes] found raw type: Class</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">        Class dummyClass =
          DummyClass.class;</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">        ^</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">  missing type arguments for
          generic class Class<T></div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">  where T is a type-variable:</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">    T extends Object declared
          in class Class</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">/Users/cthaling/ws/jdk9/hs-comp/hotspot/test/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/ReadConstantArrayElementDataProvider.java:244:

          warning: [rawtypes] found raw type: Class</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">        Class componentType =
          arrayField.getType().getComponentType();</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">        ^</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">  missing type arguments for
          generic class Class<T></div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">  where T is a type-variable:</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">    T extends Object declared
          in class Class</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">5 warnings</div>
        <div class=""><br class="">
        </div>
      </div>
      <div>Please fix them.</div>
      <div><br class="">
      </div>
      <div>It seems you didn’t run checkstyle because I’m still seeing a
        lot of errors.</div>
      <div><br class="">
      </div>
      <div>Btw. the error when running unittest is fine:</div>
      <div><br class="">
      </div>
      <div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">There was 1 failure:</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">1)
initializationError(jdk.vm.ci.hotspot.test.HotSpotConstantReflectionProviderTest)</div>
        <div style="margin: 0px; font-size: 10px; line-height: normal;
          font-family: Monaco;" class="">java.lang.Exception: No
          runnable methods</div>
        <div class=""><br class="">
        </div>
        <div class="">There some work we have to do in mx.</div>
        <div class=""><br class="">
        </div>
        <blockquote type="cite" class="">
          <div class="">
            <div bgcolor="#FFFFFF" text="#000000" class=""> <br
                class="">
              Thanks<br class="">
              -Konstantin<br class="">
              <br class="">
              <div class="moz-cite-prefix">On 24.03.2016 19:33,
                Christian Thalinger wrote:<br class="">
              </div>
              <blockquote
                cite="mid:7B0BA921-A8D5-4D70-B526-F9B0D4762EF1@oracle.com"
                type="cite" class="">
                <meta http-equiv="Content-Type" content="text/html;
                  charset=utf-8" class="">
                <br class="">
                <div class="">
                  <blockquote type="cite" class="">
                    <div class="">On Mar 23, 2016, at 9:37 PM,
                      Konstantin Shefov <<a moz-do-not-send="true"
                        href="mailto:konstantin.shefov@oracle.com"
                        class="">konstantin.shefov@oracle.com</a>>
                      wrote:</div>
                    <br class="Apple-interchange-newline">
                    <div class="">
                      <meta content="text/html; charset=utf-8"
                        http-equiv="Content-Type" class="">
                      <div bgcolor="#FFFFFF" text="#000000" class="">
                        Hi, Christian<br class="">
                        <br class="">
                        I did as you suggested, also removed
                        jdk.test.lib.Triple, but when I execute<br
                          class="">
                        <br class="">
                        mx build --no-native<br class="">
                        <br class="">
                        I have an error<br class="">
                        <br class="">
                        /media/kshefov/OS/Users/kshefov/workspaces/jdk9-hs-comp/hotspot/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotJVMCIBackendFactory.java:125:




                        error: cannot find symbol<br class="">
                                if ((config.vmVersionFeatures &
                        config.amd64SHA) != 0) {<br class="">
                                                                      ^<br
                          class="">
                          symbol:   variable amd64SHA<br class="">
                          location: variable config of type
                        HotSpotVMConfig<br class="">
                        /media/kshefov/OS/Users/kshefov/workspaces/jdk9-hs-comp/hotspot/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotJVMCIBackendFactory.java:126:




                        error: cannot find symbol<br class="">
                                    features.add(AMD64.CPUFeature.SHA);<br
                          class="">
                                                                 ^<br
                          class="">
                          symbol:   variable SHA<br class="">
                          location: class CPUFeature<br class="">
                        2 errors<br class="">
                      </div>
                    </div>
                  </blockquote>
                  <div class=""><br class="">
                  </div>
                  What JDK are you using to build?</div>
                <div class=""><br class="">
                  <blockquote type="cite" class="">
                    <div class="">
                      <div bgcolor="#FFFFFF" text="#000000" class=""> <br
                          class="">
                        -Konstantin<br class="">
                        <br class="">
                        <div class="moz-cite-prefix">On 23.03.2016
                          22:07, Christian Thalinger wrote:<br class="">
                        </div>
                        <blockquote
                          cite="mid:A99810D8-DBF7-4125-B255-D8D47EA4A0DE@oracle.com"
                          type="cite" class="">
                          <meta http-equiv="Content-Type"
                            content="text/html; charset=utf-8" class="">
                          <br class="">
                          <div class="">
                            <blockquote type="cite" class="">
                              <div class="">On Mar 23, 2016, at 7:57 AM,
                                Christian Thalinger <<a
                                  moz-do-not-send="true"
                                  href="mailto:christian.thalinger@oracle.com"
                                  class="">christian.thalinger@oracle.com</a>>


                                wrote:</div>
                              <br class="Apple-interchange-newline">
                              <div class="">
                                <meta http-equiv="Content-Type"
                                  content="text/html; charset=utf-8"
                                  class="">
                                <div style="word-wrap: break-word;
                                  -webkit-nbsp-mode: space;
                                  -webkit-line-break:
                                  after-white-space;" class="">I need to
                                  get a change into mx.  Will get back
                                  to you.</div>
                              </div>
                            </blockquote>
                            <div class=""><br class="">
                            </div>
                            Alright.  I created an mx pull request for
                            TestNG support:</div>
                          <div class=""><br class="">
                          </div>
                          <div class=""><a moz-do-not-send="true"
                              href="https://github.com/graalvm/mx/pull/102"
                              class="">https://github.com/graalvm/mx/pull/102</a></div>
                          <div class=""><br class="">
                          </div>
                          <div class="">In the meantime you can clone my
                            mx repository on github.  Add this patch to
                            your changes:</div>
                          <div class=""><br class="">
                          </div>
                          <div class="">
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(45, 230, 33);" class="">diff -r
                              1e385207d9f2 .mx.jvmci/suite.py</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(195, 55, 32);" class="">---
                              a/.mx.jvmci/suite.py<span
                                class="Apple-tab-span"
                                style="white-space:pre"> </span>Fri Mar
                              18 15:54:47 2016 +0100</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+++
                              b/.mx.jvmci/suite.py<span
                                class="Apple-tab-span"
                                style="white-space:pre"> </span>Wed Mar
                              23 08:52:35 2016 -1000</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 187, 199);" class="">@@
                              -175,6 +175,18 @@ suite = {</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;"
                              class="">       "workingSets" : "JVMCI",</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;"
                              class="">     },</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              min-height: 14px;" class=""> <br
                                class="webkit-block-placeholder">
                            </div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+   
                              "jdk.vm.ci.hotspot.test" : {</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+     
                              "subDir" : "test/compiler/jvmci",</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+     
                              "sourceDirs" : ["src"],</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+     
                              "dependencies" : [</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+     
                                "mx:TESTNG",</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+     
                                "jdk.vm.ci.hotspot",</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+     
                              ],</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+     
                              "checkstyle" : "jdk.vm.ci.services",</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+     
                              "javaCompliance" : "1.8",</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+     
                              "workingSets" : "API,JVMCI",</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+    },</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;
                              color: rgb(52, 189, 38);" class="">+</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;"
                              class="">     "jdk.vm.ci.hotspotvmconfig"
                              : {</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;"
                              class="">       "subDir" :
                              "src/jdk.vm.ci/share/classes",</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;"
                              class="">       "sourceDirs" : ["src"],</div>
                            <div class=""><br class="">
                            </div>
                          </div>
                          <div class="">and run mx checkstyle.  You will
                            see a bunch of errors.  Fix these.  Make
                            sure JVMCI builds through mx:</div>
                          <div class=""><br class="">
                          </div>
                          <div class="">
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;"
                              class="">$ mx build --no-native</div>
                          </div>
                          <div class=""><br class="">
                          </div>
                          <div class="">The biggest problem I see is:</div>
                          <div class=""><br class="">
                          </div>
                          <div class="">
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;"
                              class="">/Users/cthaling/ws/jdk9/hs-comp/hotspot/test/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/ReadConstantArrayElementDataProvider.java:47:




                              error: package jdk.test.lib does not exist</div>
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;"
                              class="">import jdk.test.lib.Triple;</div>
                            <div class=""><br class="">
                            </div>
                            <div class="">Not sure if it really makes
                              sense to have that dependency.  After the
                              build succeeds you can run all unit tests
                              via:</div>
                            <div class=""><br class="">
                            </div>
                            <div class="">
                              <div style="margin: 0px; font-size: 10px;
                                line-height: normal; font-family:
                                Monaco;" class="">$ mx unittest</div>
                            </div>
                            <div class=""><br class="">
                            </div>
                          </div>
                          <div class="">Once that works, either open all
                            files in your favorite IDE (after doing mx
                            ideinit) and reformat the files or run:</div>
                          <div class=""><br class="">
                          </div>
                          <div class="">
                            <div style="margin: 0px; font-size: 10px;
                              line-height: normal; font-family: Monaco;"
                              class="">$ mx eclipseformat</div>
                          </div>
                          <div class=""><br class="">
                          </div>
                          <div class="">
                            <blockquote type="cite" class="">
                              <div class="">
                                <div style="word-wrap: break-word;
                                  -webkit-nbsp-mode: space;
                                  -webkit-line-break:
                                  after-white-space;" class="">
                                  <div class=""><br class="">
                                    <div class="">
                                      <blockquote type="cite" class="">
                                        <div class="">On Mar 22, 2016,
                                          at 1:50 AM, Konstantin Shefov
                                          <<a moz-do-not-send="true"
href="mailto:konstantin.shefov@oracle.com" class="">konstantin.shefov@oracle.com</a>>



                                          wrote:</div>
                                        <br
                                          class="Apple-interchange-newline">
                                        <div class="">
                                          <meta content="text/html;
                                            charset=utf-8"
                                            http-equiv="Content-Type"
                                            class="">
                                          <div text="#000000"
                                            bgcolor="#FFFFFF" class="">
                                            Hi, Christian<br class="">
                                            <br class="">
                                            Thanks for reviewing.<br
                                              class="">
                                            <br class="">
                                            Here is the new patch <a
                                              moz-do-not-send="true"
                                              class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ekshefov/8152344/webrev.01/">http://cr.openjdk.java.net/~kshefov/8152344/webrev.01/</a><br
                                              class="">
                                            <br class="">
                                            I moved tests to the folder
                                            hotspot/test/compiler/jvmci/jdk.vm.ci.hotspot.test


                                            and tho the package
                                            jdk.vm.ci.hotspot.test. Also
                                            I have done some code
                                            re-formatting.<br class="">
                                            <br class="">
                                            -Konstantin<br class="">
                                            <br class="">
                                            <div class="moz-cite-prefix">On


                                              03/22/2016 12:20 AM,
                                              Christian Thalinger wrote:<br
                                                class="">
                                            </div>
                                            <blockquote
                                              cite="mid:6531E2CB-D814-4A7D-B7AA-6A65A57ABB67@oracle.com"
                                              type="cite" class="">
                                              <meta
                                                http-equiv="Content-Type"
                                                content="text/html;
                                                charset=utf-8" class="">
                                              Sorry but I have to bring
                                              this up again… there is so
                                              much line-breaking going
                                              on it’s ridiculous.
                                               Especially in:
                                              <div class=""><br class="">
                                              </div>
                                              <div class=""><a
                                                  moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ekshefov/8152344/webrev.00/test/compiler/jvmci/constantReflectionProviderTest/BoxPrimitiveDataProvider.java.html"
                                                  class="">http://cr.openjdk.java.net/~kshefov/8152344/webrev.00/test/compiler/jvmci/constantReflectionProviderTest/BoxPrimitiveDataProvider.java.html</a><br
                                                  class="">
                                                <div class=""><br
                                                    class="">
                                                </div>
                                                <div class="">Or this:</div>
                                                <div class="">
                                                  <pre style="background-color: rgb(238, 238, 238);" class=""> 118         Assert.assertEquals(CONSTANT_REFLECTION_PROVIDER.readStableFieldValue(field,
 119                                                                               receiver,
 120                                                                               isDefStab),
 121                 expected, "Unexpected result:");</pre>
                                                  <div class=""><br
                                                      class="">
                                                  </div>
                                                  <div class="">Here is
                                                    a suggestion.  Move
                                                    your tests into the
                                                    package
                                                    jdk.vm.ci.hotspot.test
                                                    under:</div>
                                                  <div class=""><br
                                                      class="">
                                                  </div>
                                                  <div class="">hotspot/test/compiler/jvmci/jdk.vm.ci.hotspot.test</div>
                                                  <div class=""><br
                                                      class="">
                                                  </div>
                                                  <div class="">Look at
                                                    jdk.vm.ci.runtime.test

                                                    as an example.  Then
                                                    we
                                                    add jdk.vm.ci.hotspot.test to
                                                    the mx configuration
                                                    file and let the
                                                    predefined
                                                    formatting rules
                                                    take care of it.</div>
                                                  <div class=""><br
                                                      class="">
                                                  </div>
                                                  <div class="">This
                                                    would be my
                                                    preferred way
                                                    because then the
                                                    tests are
                                                    automatically
                                                    imported into IDEs
                                                    as well.  Actually
                                                    all JVMCI tests
                                                    should do it this
                                                    way.</div>
                                                  <div class=""><br
                                                      class="">
                                                    <div class="">
                                                      <blockquote
                                                        type="cite"
                                                        class="">
                                                        <div class="">On
                                                          Mar 21, 2016,
                                                          at 11:07 AM,
                                                          Konstantin
                                                          Shefov <a
                                                          moz-do-not-send="true"
class="moz-txt-link-rfc2396E" href="mailto:konstantin.shefov@oracle.com"><konstantin.shefov@oracle.com></a>
                                                          wrote:</div>
                                                        <br
                                                          class="Apple-interchange-newline">
                                                        <div class="">
                                                          <div class="">Hello<br
                                                          class="">
                                                          <br class="">
                                                          Please review
                                                          some new unit
                                                          tests for
                                                          methods of
                                                          JVMCI
                                                          jdk.vm.ci.hotspot.HotSpotConstantReflectionProvider
                                                          class.<br
                                                          class="">
                                                          <br class="">
                                                          The tests
                                                          cover most
                                                          public methods
                                                          of the class
                                                          named above.<br
                                                          class="">
                                                          <br class="">
                                                          Here
                                                          "test/compiler/jvmci/constantReflectionProviderTest/HotSpotConstantReflectionProviderTest.java"





                                                          is the
                                                          JTREG-testng
                                                          file, all
                                                          other classes
                                                          are testng
                                                          data
                                                          providers,
                                                          except
                                                          TestHelper.java
                                                          and
                                                          DummyClass.java
                                                          that store all
                                                          necessary
                                                          variables.<br
                                                          class="">
                                                          <br class="">
                                                          Bug: <a
                                                          moz-do-not-send="true"
class="moz-txt-link-freetext"
                                                          href="https://bugs.openjdk.java.net/browse/JDK-8152344">https://bugs.openjdk.java.net/browse/JDK-8152344</a><br
                                                          class="">
                                                          Webrev: <a
                                                          moz-do-not-send="true"
class="moz-txt-link-freetext"
                                                          href="http://cr.openjdk.java.net/%7Ekshefov/8152344/webrev.00/">http://cr.openjdk.java.net/~kshefov/8152344/webrev.00/</a><br
                                                          class="">
                                                          <br class="">
                                                          Thanks<br
                                                          class="">
                                                          -Konstantin<br
                                                          class="">
                                                          <br class="">
                                                          </div>
                                                        </div>
                                                      </blockquote>
                                                    </div>
                                                    <br class="">
                                                  </div>
                                                </div>
                                              </div>
                                            </blockquote>
                                            <br class="">
                                          </div>
                                        </div>
                                      </blockquote>
                                    </div>
                                    <br class="">
                                  </div>
                                </div>
                              </div>
                            </blockquote>
                          </div>
                          <br class="">
                        </blockquote>
                        <br class="">
                      </div>
                    </div>
                  </blockquote>
                </div>
                <br class="">
              </blockquote>
              <br class="">
            </div>
          </div>
        </blockquote>
      </div>
      <br class="">
    </blockquote>
    <br>
  </body>
</html>