<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <br>
    <div class="moz-cite-prefix">Please take a look at v04 with this
      issue fixed.<br>
      <br>
      <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dpochepk/8152341/webrev.04">http://cr.openjdk.java.net/~dpochepk/8152341/webrev.04</a><br>
      <br>
      Thanks,<br>
      Dmitrij<br>
    </div>
    <blockquote
      cite="mid:20918FD9-C9AB-4704-88C8-526BC971ACE9@oracle.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      <br class="">
      <div>
        <blockquote type="cite" class="">
          <div class="">On May 10, 2016, at 6:51 AM, Dmitrij Pochepko
            <<a moz-do-not-send="true"
              href="mailto:dmitrij.pochepko@oracle.com" class="">dmitrij.pochepko@oracle.com</a>>
            wrote:</div>
          <br class="Apple-interchange-newline">
          <div class="">
            <div class="">Hi,<br class="">
              <br class="">
              I've prepared v03 with no checkstyle errors by creating
              larger lines.<br class="">
              <br class="">
              <a moz-do-not-send="true"
                href="http://cr.openjdk.java.net/%7Edpochepk/8152341/webrev.03/"
                class="">http://cr.openjdk.java.net/~dpochepk/8152341/webrev.03/</a></div>
          </div>
        </blockquote>
        <pre style="background-color: rgb(238, 238, 238);" class="">  90     @Test(dataProvider = "negative", dataProviderClass = MemoryAccessProviderData.class, expectedExceptions = {IllegalArgumentException.class })
  91     public void testNegativeReadPrimitiveConstant(JavaKind kind, Constant base) {
  92         PROVIDER.readPrimitiveConstant(kind, base, 0L,
  93                 kind == null ? 0 : kind.getBitCount());
  94     }
</pre>
        <div class="">The formatting still looks odd.  I’ve noticed that
          sometimes Eclipse doesn’t merge lines when it actually could.
           Doug, have you noticed that too?</div>
        <div class=""><br class="">
        </div>
        <blockquote type="cite" class="">
          <div class="">
            <div class=""><br class="">
              Thanks,<br class="">
              Dmitrij<br class="">
              <blockquote type="cite" class="">
                <blockquote type="cite" class="">On 10 May 2016, at
                  16:33, Dmitrij Pochepko <<a moz-do-not-send="true"
                    href="mailto:dmitrij.pochepko@oracle.com" class="">dmitrij.pochepko@oracle.com</a>>
                  wrote:<br class="">
                  <br class="">
                  Hi,<br class="">
                  <br class="">
                  Yes. I was using netbeans. I've applied eclipse
                  formatter, then run mx checkstyle and fixed all
                  warnings except " '.' is preceded with whitespace".
                  Fixing this warning will make huge lines.<br class="">
                </blockquote>
                You can disable the formatter with:<br class="">
                <br class="">
                // @formatter:off<br class="">
                <br class="">
                code that won’t be formatted<br class="">
                <br class="">
                // @formatter:on<br class="">
                <br class="">
                However, the lines don’t look so long to me - maybe you
                need to get a larger monitor ;-)<br class="">
                <br class="">
                -Doug<br class="">
                <br class="">
                <blockquote type="cite" class="">Thanks,<br class="">
                  Dmitrij<br class="">
                  <blockquote type="cite" class="">
                    <blockquote type="cite" class="">On May 6, 2016, at
                      4:38 AM, Dmitrij Pochepko <<a
                        moz-do-not-send="true"
                        href="mailto:dmitrij.pochepko@oracle.com"
                        class=""><a class="moz-txt-link-abbreviated" href="mailto:dmitrij.pochepko@oracle.com">dmitrij.pochepko@oracle.com</a></a>>
                      wrote:<br class="">
                      <br class="">
                      Hi,<br class="">
                      <br class="">
                      please review patch for 8152341 - JVMCI test task:
                      Unit tests for MemoryAccessProvider<br class="">
                      <br class="">
                      A new tests were added for MemoryAccessProvider
                      implementation. This patch contains tests for all
                      MemoryAccessProvider methods (mostly a positive
                      and few negative tests per method). A testng
                      framework is used.<br class="">
                      <br class="">
                      webrev: <a moz-do-not-send="true"
                        href="http://cr.openjdk.java.net/%7Edpochepk/8152341/webrev.01/"
                        class="">http://cr.openjdk.java.net/~dpochepk/8152341/webrev.01/</a><br
                        class="">
                    </blockquote>
                    These two files don’t look like they have been
                    formatted properly.  Did you use an IDE to edit
                    these?<br class="">
                    <br class="">
                    <blockquote type="cite" class="">CR: <a
                        moz-do-not-send="true"
                        href="https://bugs.openjdk.java.net/browse/JDK-8152341"
                        class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8152341">https://bugs.openjdk.java.net/browse/JDK-8152341</a></a><br
                        class="">
                      <br class="">
                      I've tested it on linux_x64<br class="">
                      <br class="">
                      Thanks,<br class="">
                      Dmitrij<br class="">
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <br class="">
            </div>
          </div>
        </blockquote>
      </div>
      <br class="">
    </blockquote>
    <br>
  </body>
</html>