<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
        {font-family:Tahoma;
        panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
        {font-family:Consolas;
        panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
        {font-family:Monaco;
        panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        margin-bottom:.0001pt;
        font-size:12.0pt;
        font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:blue;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:purple;
        text-decoration:underline;}
pre
        {mso-style-priority:99;
        mso-style-link:"HTML Preformatted Char";
        margin:0in;
        margin-bottom:.0001pt;
        font-size:10.0pt;
        font-family:"Courier New";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
        {mso-style-priority:99;
        mso-style-link:"Balloon Text Char";
        margin:0in;
        margin-bottom:.0001pt;
        font-size:8.0pt;
        font-family:"Tahoma","sans-serif";}
span.apple-converted-space
        {mso-style-name:apple-converted-space;}
span.HTMLPreformattedChar
        {mso-style-name:"HTML Preformatted Char";
        mso-style-priority:99;
        mso-style-link:"HTML Preformatted";
        font-family:Consolas;}
span.changed
        {mso-style-name:changed;}
span.new
        {mso-style-name:new;}
span.il
        {mso-style-name:il;}
span.BalloonTextChar
        {mso-style-name:"Balloon Text Char";
        mso-style-priority:99;
        mso-style-link:"Balloon Text";
        font-family:"Tahoma","sans-serif";}
span.EmailStyle25
        {mso-style-type:personal-reply;
        font-family:"Calibri","sans-serif";
        color:#1F497D;}
.MsoChpDefault
        {mso-style-type:export-only;
        font-size:10.0pt;}
@page WordSection1
        {size:8.5in 11.0in;
        margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
        {page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">HI Christian<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">We have not heard from runtime team regarding this change.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Shall we go ahead with the current solution ?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I can send out the latest webrev.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Let me know your thoughts.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Vivek
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Christian Thalinger [mailto:christian.thalinger@oracle.com]
<br>
<b>Sent:</b> Monday, May 02, 2016 3:44 PM<br>
<b>To:</b> Deshpande, Vivek R<br>
<b>Cc:</b> Viswanathan, Sandhya; hotspot compiler; hotspot-runtime-dev@openjdk.java.net runtime<br>
<b>Subject:</b> Re: RFR (S): 8154473: Update for CompilerDirectives to control stub generation and intrinsics<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On May 2, 2016, at 11:53 AM, Deshpande, Vivek R <<a href="mailto:vivek.r.deshpande@intel.com">vivek.r.deshpande@intel.com</a>> wrote:<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt">Hi Christian</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt">I had tried using call_VM_leaf() which you mentioned.</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt">But this function</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;color:#931A68"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;color:#931A68">void</span><span class="apple-converted-space"><span style="font-size:8.5pt"> </span></span><span style="font-size:8.5pt">MacroAssembler::call_VM_leaf(<span style="color:#006141">address</span><span class="apple-converted-space"> </span>entry_point,<span class="apple-converted-space"> </span><span style="color:#931A68">int</span><span class="apple-converted-space"> </span>number_of_arguments)
 {</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt">  call_VM_leaf_base(entry_point, number_of_arguments);</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt">}</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt">ends up calling</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas;color:blue;background:white">void<span class="apple-converted-space"> </span></span><span style="font-size:9.5pt;font-family:Consolas;color:#2B91AF;background:white">InterpreterMacroAssembler</span><span style="font-size:9.5pt;font-family:Consolas;background:white">::call_VM_leaf_base(<span style="color:#2B91AF">address</span><span class="apple-converted-space"> </span><span style="color:gray">entry_point</span>,</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas;background:white">                                                 <span class="apple-converted-space"> </span><span style="color:blue">int</span><span class="apple-converted-space"> </span><span style="color:gray">number_of_arguments</span>)
 {</span><span class="apple-converted-space"><span style="font-size:9.5pt;font-family:Consolas"> </span></span><span style="font-size:9.5pt;font-family:Consolas">...</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas">from interp_masm_x86.cpp instead of</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas;color:blue;background:white">void</span><span class="apple-converted-space"><span style="font-size:9.5pt;font-family:Consolas;background:white"> </span></span><span style="font-size:9.5pt;font-family:Consolas;color:#2B91AF;background:white">MacroAssembler</span><span style="font-size:9.5pt;font-family:Consolas;background:white">::call_VM_leaf_base(<span style="color:#2B91AF">address</span><span class="apple-converted-space"> </span><span style="color:gray">entry_point</span>,<span class="apple-converted-space"> </span><span style="color:blue">int</span><span class="apple-converted-space"> </span><span style="color:gray">num_args</span>)
 {</span><span class="apple-converted-space"><span style="font-size:9.5pt;font-family:Consolas"> </span></span><span style="font-size:9.5pt;font-family:Consolas">…</span><o:p></o:p></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">Frankly, I didn’t know that there is an overload for call_VM_leaf_base in InterpreterMacroAssembler.  So this means there are two options:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">a)  Add a method in MacroAssembler to call MacroAssembler::call_VM_leaf_base (what you did) or<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">b)  Add InterpreterMacroAssembler::call_VM_leaf and change MacroAssembler::call_VM_leaf to do:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Monaco","serif";color:#931A68">void</span><span style="font-size:8.5pt;font-family:"Monaco","serif""> MacroAssembler::call_VM_leaf(<span style="color:#006141">address</span> entry_point,
<span style="color:#931A68">int</span> number_of_arguments) {<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Monaco","serif"">  MacroAssembler::call_VM_leaf_base(entry_point, number_of_arguments);<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Monaco","serif"">}<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I will let the runtime team decide.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas">So I had put mathfunc() to call the masm version of call_VM_leaf_base().</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas">Let me know what you think.</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:Consolas">Thanks and regards,<br>
Vivek</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<div>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span class="apple-converted-space"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span></span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Christian
 Thalinger [<a href="mailto:christian.thalinger@oracle.com">mailto:christian.thalinger@oracle.com</a>]<span class="apple-converted-space"> </span><br>
<b>Sent:</b><span class="apple-converted-space"> </span>Monday, May 02, 2016 1:50 PM<br>
<b>To:</b><span class="apple-converted-space"> </span>Deshpande, Vivek R<br>
<b>Cc:</b><span class="apple-converted-space"> </span><a href="mailto:hotspot-compiler-dev@openjdk.java.net">hotspot-compiler-dev@openjdk.java.net</a><br>
<b>Subject:</b><span class="apple-converted-space"> </span>Re: RFR (S): 8154473: Update for CompilerDirectives to control stub generation and intrinsics</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal">On Apr 26, 2016, at 8:53 PM, Deshpande, Vivek R <<a href="mailto:vivek.r.deshpande@intel.com"><span style="color:purple">vivek.r.deshpande@intel.com</span></a>> wrote:<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi Christian</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I have updated the webrev and link for the same is here:</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><a href="http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.03/"><span style="color:purple">http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.03/</span></a></span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I am using mathfunc() to call the masm version of call_VM_leaf_base() and not the InterpreterMacroAssembler version.</span><o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal">That’s better but, again, there is nothing math-y about this method:<o:p></o:p></p>
</div>
</div>
<div>
<pre style="background:#EEEEEE"><span class="changed"><span style="color:blue">! void MacroAssembler::mathfunc(address runtime_entry) {</span></span><o:p></o:p></pre>
<pre style="background:#EEEEEE">    MacroAssembler::call_VM_leaf_base(runtime_entry, 0);<o:p></o:p></pre>
<pre style="background:#EEEEEE">  }<o:p></o:p></pre>
<div>
<div>
<p class="MsoNormal">Also, there is this method:<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Monaco","serif";color:#931A68">void</span><span class="apple-converted-space"><span style="font-size:8.5pt;font-family:"Monaco","serif""> </span></span><span style="font-size:8.5pt;font-family:"Monaco","serif"">MacroAssembler::call_VM_leaf(<span style="color:#006141">address</span><span class="apple-converted-space"> </span>entry_point,<span class="apple-converted-space"> </span><span style="color:#931A68">int</span><span class="apple-converted-space"> </span>number_of_arguments)
 {</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Monaco","serif"">  call_VM_leaf_base(entry_point, number_of_arguments);</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Monaco","serif"">}</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal">which has:<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Monaco","serif"">  <span style="color:#931A68">void</span><span class="apple-converted-space"> </span>call_VM_leaf(<span style="color:#006141">address</span><span class="apple-converted-space"> </span>entry_point,</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Monaco","serif"">                   <span class="apple-converted-space"> </span><span style="color:#931A68">int</span><span class="apple-converted-space"> </span>number_of_arguments = 0);</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal">Get rid of mathfunc completely and use call_VM_leaf directly.<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Regards,</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Vivek</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Monaco","serif""> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span></a><o:p></o:p></p>
</div>
</div>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<div>
<div>
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">From:</span></b><span class="apple-converted-space"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span></span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Christian
 Thalinger [<a href="mailto:christian.thalinger@oracle.com"><span style="color:purple">mailto:christian.thalinger@oracle.com</span></a>]<span class="apple-converted-space"> </span><br>
<b>Sent:</b><span class="apple-converted-space"> </span>Thursday, April 21, 2016 2:35 PM<br>
<b>To:</b><span class="apple-converted-space"> </span>Deshpande, Vivek R <<a href="mailto:vivek.r.deshpande@intel.com"><span style="color:purple">vivek.r.deshpande@intel.com</span></a>><br>
<b>Cc:</b><span class="apple-converted-space"> </span>Nils Eliasson <<a href="mailto:nils.eliasson@oracle.com"><span style="color:purple">nils.eliasson@oracle.com</span></a>>;<span class="apple-converted-space"> </span><a href="mailto:hotspot-compiler-dev@openjdk.java.net"><span style="color:purple">hotspot-compiler-dev@openjdk.java.net</span></a>;
 Vladimir Kozlov <<a href="mailto:vladimir.kozlov@oracle.com"><span style="color:purple">vladimir.kozlov@oracle.com</span></a>><br>
<b>Subject:</b><span class="apple-converted-space"> </span>Re: RFR (S): 8154473: Update for CompilerDirectives to control stub generation and intrinsics</span><o:p></o:p></p>
</div>
</div>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<div>
<p class="MsoNormal">On Apr 20, 2016, at 2:13 PM, Deshpande, Vivek R <<a href="mailto:vivek.r.deshpande@intel.com"><span style="color:purple">vivek.r.deshpande@intel.com</span></a>> wrote:<o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">The correct URL for the updated webrev is this.</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><a href="http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.02/"><span style="color:purple">http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.02/</span></a></span><o:p></o:p></p>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
</div>
<pre style="background:#EEEEEE;background-position:initial initial;background-repeat:initial initial"><span class="new"><span style="color:blue">+void MacroAssembler::mathfunc(address runtime_entry) {</span></span><o:p></o:p></pre>
<div>
<div>
<p class="MsoNormal">I don’t like the name of this method.  Mainly because it’s only aligning the stack (shouldn’t that happen somewhere else?) and doing this 0x20 stack frame thing which I still don’t understand.<o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal">Right, this is the one I was thinking about:<o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Monaco","serif";color:#931A68">void</span><span class="apple-converted-space"><span style="font-size:8.5pt;font-family:"Monaco","serif""> </span></span><span style="font-size:8.5pt;font-family:"Monaco","serif"">MacroAssembler::call_VM_leaf_base(<span style="color:#006141">address</span><span class="apple-converted-space"> </span>entry_point,<span class="apple-converted-space"> </span><span style="color:#931A68">int</span><span class="apple-converted-space"> </span>num_args)
 {</span><o:p></o:p></p>
</div>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><br>
<br>
<br>
<br>
<o:p></o:p></p>
</div>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Sorry for the spam.</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Regards,</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Vivek</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span class="apple-converted-space"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span></span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Deshpande,
 Vivek R<span class="apple-converted-space"> </span><br>
<b>Sent:</b><span class="apple-converted-space"> </span>Wednesday, April 20, 2016 5:10 PM<br>
<b>To:</b><span class="apple-converted-space"> </span>Deshpande, Vivek R; 'Nils Eliasson'; '<a href="mailto:hotspot-compiler-dev@openjdk.java.net"><span style="color:purple">hotspot-compiler-dev@openjdk.java.net</span></a>'<br>
<b>Cc:</b><span class="apple-converted-space"> </span>'Vladimir Kozlov'; 'Volker Simonis'; 'Christian Thalinger'; Viswanathan, Sandhya<br>
<b>Subject:</b><span class="apple-converted-space"> </span>RE: RFR (S): 8154473: Update for CompilerDirectives to control stub generation and intrinsics</span><o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Sent out the wrong link by mistake.</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:9.5pt;font-family:"Arial","sans-serif";color:#333333;background:whitesmoke">updated webrev:<span class="apple-converted-space"> </span></span><span style="font-size:9.5pt;font-family:"Arial","sans-serif";color:#333333"><br>
</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><a href="http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.01/"><span style="font-size:9.5pt;font-family:"Arial","sans-serif";color:#3B73AF;background:whitesmoke;text-decoration:none">http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.02/</span></a></span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Regards</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Vivek</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span class="apple-converted-space"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span></span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Deshpande,
 Vivek R<span class="apple-converted-space"> </span><br>
<b>Sent:</b><span class="apple-converted-space"> </span>Wednesday, April 20, 2016 5:07 PM<br>
<b>To:</b><span class="apple-converted-space"> </span>'Nils Eliasson';<span class="apple-converted-space"> </span><a href="mailto:hotspot-compiler-dev@openjdk.java.net"><span style="color:purple">hotspot-compiler-dev@openjdk.java.net</span></a><br>
<b>Cc:</b><span class="apple-converted-space"> </span>Vladimir Kozlov; Volker Simonis; Christian Thalinger; Viswanathan, Sandhya<br>
<b>Subject:</b><span class="apple-converted-space"> </span>RE: RFR (S): 8154473: Update for CompilerDirectives to control stub generation and intrinsics</span><o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi Nils</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I have updated the webrev with all the suggestions.</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:9.5pt;font-family:"Arial","sans-serif";color:#333333;background:whitesmoke">updated webrev:<span class="apple-converted-space"> </span></span><span style="font-size:9.5pt;font-family:"Arial","sans-serif";color:#333333"><br>
</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><a href="http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.01/"><span style="font-size:9.5pt;font-family:"Arial","sans-serif";color:#3B73AF;background:whitesmoke;text-decoration:none">http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.01/</span></a></span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Thanks for your comments and review.</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">@Vladimir,</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">I have taken care of all the comments. Would you please review and sponsor the patch.</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Thanks and regards,</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Vivek<span class="apple-converted-space"> </span></span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span class="apple-converted-space"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span></span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Nils
 Eliasson [<a href="mailto:nils.eliasson@oracle.com"><span style="color:purple">mailto:nils.eliasson@oracle.com</span></a>]<span class="apple-converted-space"> </span><br>
<b>Sent:</b><span class="apple-converted-space"> </span>Wednesday, April 20, 2016 12:27 PM<br>
<b>To:</b><span class="apple-converted-space"> </span>Deshpande, Vivek R;<span class="apple-converted-space"> </span><a href="mailto:hotspot-compiler-dev@openjdk.java.net"><span style="color:purple">hotspot-compiler-dev@openjdk.java.net</span></a><br>
<b>Cc:</b><span class="apple-converted-space"> </span>Vladimir Kozlov; Volker Simonis; Christian Thalinger; Viswanathan, Sandhya<br>
<b>Subject:</b><span class="apple-converted-space"> </span>Re: RFR (S): 8154473: Update for CompilerDirectives to control stub generation and intrinsics</span><o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><o:p></o:p></p>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">In vmSymbols.cpp together with the other flag checks.<br>
<br>
Regards,<br>
Nils</span><o:p></o:p></p>
<div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">On 2016-04-20 02:44, Deshpande, Vivek R wrote:</span><o:p></o:p></p>
</div>
</div>
</div>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">HI Nils</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Yes you are right the function accesses the command line flag DisableIntrinsic and changes are static.</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Could you point me the right location for the function ?</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Also I have updated the webrev with rest of the comments here:</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><a href="http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.01/"><span style="color:purple">http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.01/</span></a></span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Regards,</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Vivek</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span class="apple-converted-space"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span></span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">hotspot-compiler-dev
 [<a href="mailto:hotspot-compiler-dev-bounces@openjdk.java.net"><span style="color:purple">mailto:hotspot-compiler-dev-bounces@openjdk.java.net</span></a>]<b>On Behalf Of<span class="apple-converted-space"> </span></b>Nils Eliasson<br>
<b>Sent:</b><span class="apple-converted-space"> </span>Tuesday, April 19, 2016 5:55 AM<br>
<b>To:</b><span class="apple-converted-space"> </span><a href="mailto:hotspot-compiler-dev@openjdk.java.net"><span style="color:purple">hotspot-compiler-dev@openjdk.java.net</span></a><br>
<b>Subject:</b><span class="apple-converted-space"> </span>Re: RFR (S): 8154473: Update for CompilerDirectives to control stub generation and intrinsics</span><o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><o:p></o:p></p>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Hi Vivek,<br>
<br>
The changes in is_intrinsic_disabled in compilerDirectives.* are static and only access the command line flag DisableIntrinsics. As long as stubs are only generated during startup and don't have a method context - that is ok - but it doesn't belong in the compilerDirectives-files
 if it doens't use directives. <span class="apple-converted-space"> </span><br>
<br>
Regards,<br>
Nils</span><o:p></o:p></p>
<div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">On 2016-04-18 19:38, Deshpande, Vivek R wrote:</span><o:p></o:p></p>
</div>
</div>
</div>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi all</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I would like to contribute a patch which helps to control<span class="apple-converted-space"> </span><span class="il">the intrinsics
 in interpreter, c1 and c2 by disabling the stub generation.</span></span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span class="il"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">This uses -XX:DisableIntrinsic option to achieve the same.</span></span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Could you please review and sponsor this patch.</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Bug-id: </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><a href="https://bugs.openjdk.java.net/browse/JDK-8154473"><span style="color:purple">https://bugs.openjdk.java.net/browse/JDK-8154473</span></a><br>
webrev:</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><a href="http://cr.openjdk.java.net/%7Evdeshpande/CompilerDirectives/8154473/webrev.00/"><span style="color:purple">http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webrev.00/</span></a></span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#222222"> </span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;background:white">Thanks and regards,</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;background:white">Vivek</span><o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
</blockquote>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>