<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 11, 2016, at 10:43 AM, Dmitrij Pochepko <<a href="mailto:dmitrij.pochepko@oracle.com" class="">dmitrij.pochepko@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
  
    <meta content="text/html; charset=windows-1252" http-equiv="Content-Type" class="">
  
  <div text="#000000" bgcolor="#FFFFFF" class="">
    Also performed mx eclipseformat and checkstyle and prepared v04<br class="">
    <br class="">
    <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dpochepk/8152343/webrev.04/">http://cr.openjdk.java.net/~dpochepk/8152343/webrev.04/</a><br class=""></div></div></blockquote><div><br class=""></div>That looks good.</div><div><br class=""><blockquote type="cite" class=""><div class=""><div text="#000000" bgcolor="#FFFFFF" class="">
    <br class="">
    Thanks,<br class="">
    Dmitrij<br class="">
    <blockquote cite="mid:57337FDE.2020600@oracle.com" type="cite" class="">
      <meta content="text/html; charset=windows-1252" http-equiv="Content-Type" class="">
      Hi,<br class="">
      <br class="">
      i've added encoded values generation and changed test code to
      verify expected values based on generation input values.<br class="">
      <br class="">
      Please take a look at <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Edpochepk/8152343/webrev.03/">http://cr.openjdk.java.net/~dpochepk/8152343/webrev.03/</a><br class="">
      <br class="">
      Thanks,<br class="">
      Dmitrij<br class="">
      <blockquote cite="mid:BC82ABAD-E266-4428-9AE5-A18B854D5754@oracle.com" type="cite" class="">
        <meta http-equiv="Content-Type" content="text/html;
          charset=windows-1252" class="">
        <br class="">
        <div class="">
          <blockquote type="cite" class="">
            <div class="">On May 7, 2016, at 11:41 AM, dmitrij pochepko
              <<a moz-do-not-send="true" href="mailto:dmitrij.pochepko@oracle.com" class="">dmitrij.pochepko@oracle.com</a>>

              wrote:</div>
            <br class="Apple-interchange-newline">
            <div class="">
              <blockquote cite="mid:8CE8A2DA-4E8A-47F6-86E1-E083442F7B2C@oracle.com" type="cite" style="font-family: Verdana; font-size:
                12px; font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class=""><br class="Apple-interchange-newline">
                <br class="">
                <div class="">
                  <blockquote type="cite" class="">
                    <div class="">On May 6, 2016, at 4:25 AM, Dmitrij
                      Pochepko <<a moz-do-not-send="true" href="mailto:dmitrij.pochepko@oracle.com" class="">dmitrij.pochepko@oracle.com</a>>
                      wrote:</div>
                    <br class="Apple-interchange-newline">
                    <div class="">
                      <div class="">Hi,<br class="">
                        <br class="">
                        please review patch for 8152343: JVMCI test
                        tasks: Unit tests for MetaAccessProvider<br class="">
                        <br class="">
                        A new tests were added for
                        jdk.vm.ci.meta.MetaAccessProvider
                        implementation. An existing
                        TestMetaAccessProvider.java was used to add new
                        tests.<br class="">
                        <br class="">
                        webrev:<span class="Apple-converted-space"> </span><a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Edpochepk/8152343/webrev.01/"></a><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dpochepk/8152343/webrev.01/">http://cr.openjdk.java.net/~dpochepk/8152343/webrev.01/</a></div>
                    </div>
                  </blockquote>
                  <pre class="" style="background-color: rgb(238, 238, 238);"><span class="new" style="color: blue;">+    private static final int[] VALID_ENCODED_VALUES = new int[]{-180, -436, -10932, -2147483572};</span></pre>
                </div>
              </blockquote>
              <blockquote cite="mid:8CE8A2DA-4E8A-47F6-86E1-E083442F7B2C@oracle.com" type="cite" style="font-family: Verdana; font-size:
                12px; font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
                <div class="">What are these values?  Maybe it would
                  make more sense to have them in hex-form?</div>
              </blockquote>
              <span style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255); float: none;
                display: inline !important;" class="">These values are
                encoded values for deoptReason=Aliasing,
                deoptAction=InvalidateRecompile and debugId={0, 1, 42,
                8388607}</span><br style="font-family: Verdana;
                font-size: 12px; font-style: normal; font-variant-caps:
                normal; font-weight: normal; letter-spacing: normal;
                orphans: auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
              <span style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255); float: none;
                display: inline !important;" class="">so, we have 0, 1,
                <some non-border value>, 0x7FFFFF which is a
                maximum debugId value here(all 23 bits set)</span><br style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
              <br style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
              <span style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255); float: none;
                display: inline !important;" class="">I've created
                another webrev with hex values and respective comment
                added.</span><br style="font-family: Verdana; font-size:
                12px; font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
              <br style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
              <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Edpochepk/8152343/webrev.02" style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);">http://cr.openjdk.java.net/~dpochepk/8152343/webrev.02</a><br style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
            </div>
          </blockquote>
          <div class=""><br class="">
          </div>
          Better but I still donít like them being hardcoded.  You
          should calculate the values with some defined constants so
          that someone after you can understand whatís going on and be
          able to make changes.</div>
        <div class=""><br class="">
        </div>
        <div class="">Also, what is this supposed to test?</div>
        <div class="">
          <pre style="background-color: rgb(238, 238, 238);" class=""><span class="new" style="color: blue;">+    @Test</span>
<span class="new" style="color: blue;">+    public void decodeDeoptReasonTest() {</span>
<span class="new" style="color: blue;">+        for (int encoded : VALID_ENCODED_VALUES) {</span>
<span class="new" style="color: blue;">+            JavaConstant value = JavaConstant.forInt(encoded);</span>
<span class="new" style="color: blue;">+            DeoptimizationReason reason = metaAccess.decodeDeoptReason(value);</span>
<span class="new" style="color: blue;">+            DeoptimizationReason reason2 = metaAccess.decodeDeoptReason(value);</span>
<span class="new" style="color: blue;">+            assertNotNull("Expected not null reason", reason);</span>
<span class="new" style="color: blue;">+            assertEquals("Expected equal reasons", reason, reason2);</span>
<span class="new" style="color: blue;">+        }</span>
<span class="new" style="color: blue;">+    }</span></pre>
          That two invocations of the same method on the same receiver
          with the same value return the same value?  I donít see how
          that could fail.</div>
        <div class=""><br class="">
          <blockquote type="cite" class="">
            <div class=""><br style="font-family: Verdana; font-size:
                12px; font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
              <span style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255); float: none;
                display: inline !important;" class="">Thanks,</span><br style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
              <span style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255); float: none;
                display: inline !important;" class="">Dmitrij</span>
              <blockquote cite="mid:8CE8A2DA-4E8A-47F6-86E1-E083442F7B2C@oracle.com" type="cite" style="font-family: Verdana; font-size:
                12px; font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
                <div class=""><br class="">
                  <blockquote type="cite" class="">
                    <div class="">
                      <div class=""><br class="">
                        CR:<span class="Apple-converted-space"> </span><a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8152343"></a><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8152343">https://bugs.openjdk.java.net/browse/JDK-8152343</a><br class="">
                        <br class="">
                        I've tested it on linux_x64.<br class="">
                        <br class="">
                        Thanks,<br class="">
                        Dmitrij<br class="">
                      </div>
                    </div>
                  </blockquote>
                </div>
                <br class="">
              </blockquote>
              <br style="font-family: Verdana; font-size: 12px;
                font-style: normal; font-variant-caps: normal;
                font-weight: normal; letter-spacing: normal; orphans:
                auto; text-align: start; text-indent: 0px;
                text-transform: none; white-space: normal; widows: auto;
                word-spacing: 0px; -webkit-text-stroke-width: 0px;
                background-color: rgb(255, 255, 255);" class="">
              <br class="Apple-interchange-newline">
            </div>
          </blockquote>
        </div>
        <br class="">
      </blockquote>
      <br class="">
    </blockquote>
    <br class="">
  </div>

</div></blockquote></div><br class=""></body></html>