<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 12, 2016, at 11:34 AM, Christian Thalinger <<a href="mailto:christian.thalinger@oracle.com" class="">christian.thalinger@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On May 12, 2016, at 6:29 AM, Tom Rodriguez <<a href="mailto:tom.rodriguez@oracle.com" class="">tom.rodriguez@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">So can I considered this reviewed?</div></div></blockquote><div class=""><br class=""></div>Sorry, yes.</div></div></div></blockquote><div><br class=""></div><div>I forgot about it too until Doug pinged me.  Thanks!</div><div><br class=""></div><div>tom</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">tom</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Apr 28, 2016, at 4:55 PM, Tom Rodriguez <<a href="mailto:tom.rodriguez@oracle.com" class="">tom.rodriguez@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Apr 28, 2016, at 12:23 PM, Christian Thalinger <<a href="mailto:christian.thalinger@oracle.com" class="">christian.thalinger@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Apr 28, 2016, at 6:13 AM, Tom Rodriguez <<a href="mailto:tom.rodriguez@oracle.com" class="">tom.rodriguez@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><a href="http://cr.openjdk.java.net/~never/8155047/webrev" class="">http://cr.openjdk.java.net/~never/8155047/webrev</a><br class=""></div></div></blockquote><div class=""><br class=""></div><pre style="background-color: rgb(238, 238, 238);" class="">         public LeafType(ResolvedJavaType context) {
<span class="new" style="color: blue;">+            assert !context.isLeaf() : "assumption isn't required for leaf types";</span></pre>This assert is confusing.  The assumption is that a given type has no subtypes, which is also true for leaf types.  Does this assert make sure it’s not used in the wrong places?</div></div></div></blockquote><div class=""><br class=""></div><div class="">LeafType is an assumption that a dynamic type that might someday have subclasses doesn’t currently have any.  isLeaf() is a static guarantee that a type will never have subclasses, so we are asserting that we never emit a dynamic dependence for something that is statically true.  I’m open to new wording.</div><div class=""><br class=""></div><div class="">tom</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class="">findLeafConcreteSubtype should use the same machinery for the elemental type when identifying leaf array types.<br class=""><br class="">tom</div></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></body></html>