<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 15, 2017, at 8:27 PM, Yasumasa Suenaga <<a href="mailto:yasuenag@gmail.com" class="">yasuenag@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class=""><div class=""><div class=""><div class=""><div class=""><div class="">Hi all,<br class=""><br class=""></div>I've tried to use JVMCI implementation.<br class=""><br class="">HotSpotResolvedJavaMethod#setNotInlineable() is explained that <span id="gmail-l321" class="">"Manually adds a DontInline annotation to this method" in the comment, however this method seems to disable C1/C2 compile in CompilerToVM [1][2].<br class=""><br class=""></span></div><span id="gmail-l321" class="">Is this behavior correct?<br class=""></span></div><span id="gmail-l321" class="">Should we fix the comment or method name (and / or function name) or behavior in jvmciCompilerToVM.cpp ?<br class=""></span></div></div></div></div></div></blockquote><div><br class=""></div>Yes, that’s a bit confusing.  I think HotSpotResolvedJavaMethodImpl.setNotInlineable should be renamed and the documentation updated.</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><div class=""><div class=""><span id="gmail-l321" class=""><br class=""><br class=""></span></div><span id="gmail-l321" class="">I will file it to JBS if it is a bug.<br class=""><br class=""><br class=""></span></div><span id="gmail-l321" class="">Thanks,<br class=""><br class=""></span></div><span id="gmail-l321" class="">Yasumasa (ysuenaga)<br class=""><br class=""></span><div class=""><div class=""><div class=""><div class=""><div class=""><span id="gmail-l321" class=""><br class="">[1] <a href="http://hg.openjdk.java.net/jdk9/dev/hotspot/file/d6d7e5caf497/src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java#l320" class="">http://hg.openjdk.java.net/jdk9/dev/hotspot/file/d6d7e5caf497/src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java#l320</a><br class="">[2] <a href="http://hg.openjdk.java.net/jdk9/dev/hotspot/file/d6d7e5caf497/src/share/vm/jvmci/jvmciCompilerToVM.cpp#l1004" class="">http://hg.openjdk.java.net/jdk9/dev/hotspot/file/d6d7e5caf497/src/share/vm/jvmci/jvmciCompilerToVM.cpp#l1004</a><br class=""></span></div></div></div></div></div></div>
</div></blockquote></div><br class=""></body></html>