<div dir="ltr">Thank you Magnus, that's useful. <div><br></div><div>My working command line is:</div><div>    make run-test TEST="hotspot_all" JTREG="VM_OPTIONS=-Djdk.test.lib.artifacts.jcstress-tests-all=$HOME/jcstress.jar"</div><div><br></div><div>but it takes an excessively long time to run.  Are there plans for a means to cleanly disable the JCStress JTreg tests so we can efficiently run them with the JCStress harness?</div><div><br></div><div><br></div><div>Thanks,</div><div>   Stuart</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 14 September 2017 at 08:40, Magnus Ihse Bursie <span dir="ltr"><<a href="mailto:magnus.ihse.bursie@oracle.com" target="_blank">magnus.ihse.bursie@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    Stuart,<span class=""><br>
    <br>
    <div class="m_1648140265153330800moz-cite-prefix">On 2017-09-13 20:36, Stuart Monteith
      wrote:<br>
    </div>
    <blockquote type="cite">
      <div dir="ltr">
        <div>For the record, if I put my build of jcstress.jar in $HOME,
          the following allows the jcstress tests to run:<br>
        </div>
        <div><br>
        </div>
        <div>    make test TEST="hotspot_all"
EXTRA_JTREG_OPTIONS="-Djdk.<wbr>test.lib.artifacts.jcstress-<wbr>tests-all=$HOME/jcstress.jar"<br>
        </div>
        <div><br>
        </div>
        <div class="gmail_extra">From "make help" and the makefiles
          themselves, I had expected the follow to work:</div>
        <div class="gmail_extra">    make  TEST="hotspot_all"
JTREG="VM_OPTIONS=-Djdk.test.<wbr>lib.artifacts.jcstress-tests-<wbr>all=$HOME/jcstress.jar"
          test<br>
        </div>
        <div class="gmail_extra"><br>
        </div>
        <div class="gmail_extra">but it does not - the JTREG parameter
          is apparently ignored. This is unfortunate as there is a
          warning as it is a non-control variable.</div>
      </div>
    </blockquote>
    <br></span>
    You are using the "test" target, but the JTREG option is only
    available for the new "run-test" target. Using "test" will invoke
    the old testing framework, which is about to be replaced by a more
    modern and integrated one. In the long term, "test" will invoke the
    new framework, but during a transition period, "run-test" needs to
    be used.<br>
    <br>
    For what it's worth, I tried your command line (but without the
    patch applied) and verified using LOG=cmdlines that the -D option
    was indeed passed to jtreg.<span class="HOEnZb"><font color="#888888"><br>
    <br>
    /Magnus</font></span><div><div class="h5"><br>
    <br>
    <blockquote type="cite">
      <div dir="ltr">
        <div class="gmail_extra"><br>
        </div>
        <div class="gmail_extra">Am I wrong in thinking that this was
          written for testing internall within Oracle? I can not find an
          instance of  "com.oracle.jib.api.<wbr>JibServiceFactory" in the
          OpenJDK project or elsewhere.</div>
        <div class="gmail_extra"><br>
        </div>
        <div class="gmail_extra">BR,</div>
        <div class="gmail_extra">    Stuart</div>
        <div class="gmail_extra"><br>
          <div class="gmail_quote">On 8 September 2017 at 16:53, Stuart
            Monteith <span dir="ltr"><<a href="mailto:stuart.monteith@linaro.org" target="_blank">stuart.monteith@linaro.org</a>></span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
              <div dir="ltr">Hello,
                <div>  I've spent some time on this,  and I have to
                  admit that I'm stumped. I get exactly the same errors
                  on x86 on jdk10/hs and jdk10/jdk10 with arecent build
                  of JTReg and JT_HOME set appropriately.</div>
                <div><br>
                </div>
                <div>Are there any pointers on how this is supposed to
                  be run?</div>
                <div><br>
                </div>
                <div>Thanks,</div>
                <div>   Stuart</div>
              </div>
              <div class="m_1648140265153330800gmail-HOEnZb">
                <div class="m_1648140265153330800gmail-h5">
                  <div class="gmail_extra"><br>
                    <div class="gmail_quote">On 25 April 2017 at 11:47,
                      Aleksey Shipilev <span dir="ltr"><<a href="mailto:shade@redhat.com" target="_blank">shade@redhat.com</a>></span>
                      wrote:<br>
                      <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On
                          04/19/2017 12:12 AM, Igor Ignatyev wrote:<br>
                          > <a href="http://cr.openjdk.java.net/%7Eiignatyev//8178788/webrev.00/index.html" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~ii<wbr>gnatyev//8178788/webrev.00/ind<wbr>ex.html</a><br>
                          >> 69903 lines changed: 69903 ins; 0
                          del; 0 mod;<br>
                          > (69524 lines are generated)<br>
                          ><br>
                          > Hi all,<br>
                          ><br>
                          > could you please review this patch which
                          adds a jtreg test wrapper for<br>
                          > jcstress test suite and jtreg tests which
                          run jsctress tests thru this<br>
                          > wrapper?<br>
                          ><br>
                          > webrev: <a href="http://cr.openjdk.java.net/%7Eiignatyev//8178788/webrev.00/index.html" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~ii<wbr>gnatyev//8178788/webrev.00/ind<wbr>ex.html</a><br>
                          > JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8178788" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8178788</a>
                          testing:<br>
                          <br>
                        </span>TL;DR: This patch introduces more
                        problems than it solves. Just run the jcstress<br>
                        tests-all JAR against the tested runtime.<br>
                        <br>
                        Wrapping jcstress tests with jtreg defies the
                        purpose of jcstress harness --<br>
                        that is, running lots of tests as fast as it
                        possibly could without affecting<br>
                        testing quality. For example, by cleverly
                        reusing VMs between the tests, using<br>
                        Whitebox to deoptimize without restarting the
                        VMs, etc. It really wastes CPU<br>
                        time to run each test in isolation.<br>
                        <br>
                        Also, it does not "automatically" work, which
                        defies "easy to run" goal:<br>
                        <br>
                        Caused by: java.io.FileNotFoundException:
                        Couldn't automatically resolve<br>
                        dependency for jcstress-tests-all , revision 0.3<br>
                        Please specify the location using
                        jdk.test.lib.artifacts.jcstres<wbr>s-tests-all<br>
                                at<br>
                        jdk.test.lib.artifacts.Default<wbr>ArtifactManager.resolve(Defaul<wbr>tArtifactManager.java:37)<br>
                                at jdk.test.lib.artifacts.Artifac<wbr>tResolver.resolve(ArtifactReso<wbr>lver.java:54)<br>
                                at applications.jcstress.Jcstress<wbr>Runner.pathToArtifact(Jcstress<wbr>Runner.java:53)<br>
                                ... 8 more<br>
                        <br>
                        Okay, brilliant! How do I configure this, if I
                        run "make test"?<br>
                        <br>
                        CONF=linux-x86_64-normal-serve<wbr>r-release
                        LOG=info make test TEST="hotspot_all"<br>
                        <span class="m_1648140265153330800gmail-m_-1290109537211281309HOEnZb"><font color="#888888"><br>
                            <br>
                            -Aleksey<br>
                            <br>
                          </font></span></blockquote>
                    </div>
                    <br>
                  </div>
                </div>
              </div>
            </blockquote>
          </div>
          <br>
        </div>
      </div>
    </blockquote>
    <br>
  </div></div></div>

</blockquote></div><br></div>