John.Rose at Sun.COM
Wed Nov 7 20:16:35 PST 2007
Quick comment on parseHelper.cpp:
In the opto directory (C2) we try to avoid using #ifdef or LP64 when
wordSize issues. Instead, there is a pseudo-type "X" defined in opto/
as a series of macros for names which occur in both "int" and "long"
Your change can probably be rewritten to use this convention.
You might need to add a symbol or two to type.hpp, such as "T_X"
for T_INT/T_LONG. (Yes, the naming could use a cleanup.
But it's what we have, and it's far better than #ifdef.)
Thanks for doing this. I'm going to try it out (which is why I had
More information about the hotspot-dev