What happens with the review comments?

Chuck Rasbold Chuck.Rasbold at Sun.COM
Tue Oct 21 10:24:01 PDT 2008

Volker -

A number of us discussed your comment this morning.  We agreed that we 
should make a greater effort to ensure that the description in the 
"request for review" should be pasted into the evaluation part of the 
bug report, especially if it is non-trivially different than the 
existing evaluation.

Some of us already do that, but hopefully it will become standard 
operating procedure.

-- Chuck

On 10/17/08 02:14, Volker Simonis wrote:
> Hi,
> I noticed that the "request for review" mails often contain a small
> description and/or justification of a change potentially followed by a
> discussion of the change. Unfortunately, these comments are not part
> of the hg changeset which only contains the summary of the change and
> often they are also not part of the bug report.
> I remember that some time ago there was a discussion on the OpenJDK
> lists about which fields to use in a hg changeset comments and it has
> been argued, that "a more complete description of the change belongs
> in the bug report" (see
> http://openjdk.java.net/guide/producingChangeset.html) but
> unfortunately this doesn't seems to happen regularly.
> As far as I can see, the bug report now usually links back to the
> change set and finding the bug report from a change set is trivial as
> well. However the review comments are hard to find, once a change set
> is submitted. I'm really happy to see the review process for changes
> happening in the open on the OpenJDK mailing lists but I think it's a
> pity if this information doesn't go into a kind of "database" for
> future use.
> Are there any ideas how this valuable information could be preserved
> in the future (changing the policy of what goes into the change sets
> comments, somehow enforce that review comments go into the bug
> report)?
> Regards,
> Volker

More information about the hotspot-dev mailing list