[PATCH FOR REVIEW]: Make source/target options explicit for MakeDeps and jvmti
Daniel D. Daugherty
Daniel.Daugherty at Sun.COM
Tue Aug 18 07:24:14 PDT 2009
A couple of comments:
- if you specify '-source 6', then '-target 6' is implied
so you don't really need both
- I would prefer to see a top-level macro that defines the
bootstrap tools javac option and then have the various
Makefiles use that macro. Something in make/defs.make:
or something like that.
Which repo are you targeting for this change?
Yes, I see that SA uses '-source 1.4' in each platform makefile.
That should be fixed also, but that's another issue...
Andrew John Hughes wrote:
> The makeDeps and jvmti bootstrap tools are built without explicit
> source and target options.
> This webrev:
> sets them to 6 explicitly. The change has to be replicated three
> times, because for some reason, the javac invocations are in
> platform-specific makefiles. I've tested the change successfully on
> GNU/Linux, where it allows ecj to be used as javac. ecj defaults to
> <1.5 and thus otherwise fails to build. I've assumed that the same
> changes are applicable for Solaris and Windows, and that the source
> and target options don't have to be written in Latin or something to
> work on these platforms.
> Is this ok to push?
More information about the hotspot-dev