[PATCH FOR REVIEW]: Make source/target options explicit for MakeDeps and jvmti
Andrew John Hughes
gnu_andrew at member.fsf.org
Tue Aug 18 07:52:45 PDT 2009
2009/8/18 Daniel D. Daugherty <Daniel.Daugherty at sun.com>:
> A couple of comments:
> - if you specify '-source 6', then '-target 6' is implied
> so you don't really need both
The template I used for the change was the use of source/target 7 in
corba, langtools and jdk, which specify both. It seems prudent to be
explicit at the expense of some extra characters.
> - I would prefer to see a top-level macro that defines the
> bootstrap tools javac option and then have the various
> Makefiles use that macro. Something in make/defs.make:
> BOOTSTRAP_TOOLS.JAVAC.FLAGS="-source 6"
> or something like that.
Sounds sensible. I'll post another webrev with such a change; I only
saw JAVAC-related defines in the platform makefiles, so did the
simplest changes to begin with.
> Which repo are you targeting for this change?
Any of the OpenJDK7 HotSpot repositories - which do you think is most
I suppose it could also go to build, but it seems better for such a
change to be reviewed by those most dependent on building it.
> Yes, I see that SA uses '-source 1.4' in each platform makefile.
> That should be fixed also, but that's another issue...
> Andrew John Hughes wrote:
>> The makeDeps and jvmti bootstrap tools are built without explicit
>> source and target options.
>> This webrev:
>> sets them to 6 explicitly. The change has to be replicated three
>> times, because for some reason, the javac invocations are in
>> platform-specific makefiles. I've tested the change successfully on
>> GNU/Linux, where it allows ecj to be used as javac. ecj defaults to
>> <1.5 and thus otherwise fails to build. I've assumed that the same
>> changes are applicable for Solaris and Windows, and that the source
>> and target options don't have to be written in Latin or something to
>> work on these platforms.
>> Is this ok to push?
Thanks for the quick response,
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the hotspot-dev