[PATCH FOR REVIEW]: Make source/target options explicit for MakeDeps and jvmti

Daniel D. Daugherty Daniel.Daugherty at Sun.COM
Thu Aug 20 19:00:16 PDT 2009

John Coomes wrote:
>> Finally, switching SA to use the defaults would be a visible change.
> Dan mentioned the SA values in passing; my impression was he thought
> they should be updated or removed.  I don't work with the SA, but I
> suspect the settings are relics from using a boot jdk that had 1.3 as
> a default when SA needed 1.4 features.  Anyone recall?
> Even if for some odd reason SA source should be limited to using 1.4
> features, if you update JAVAC_COMPILE to include JAVAC_FLAGS (or
> whatever it is), and the SA makefile also includes -source/-target
> options on the command-line, the latter will override the ones in
> JAVAC_FLAGS (the SA command line may need to include both -source and
> -target).  At least try it, I think it'll be a simpler change.
> I submitted your latest patch to the build queue for test builds;
> hopefully it will send you mail when it's finished (but I've never
> tried including a non-Sun email address before).

I've sent a query to Sundar directly so hopefully he'll see
that instead of the alias mail... I figure he should know :-)


More information about the hotspot-dev mailing list