merge vm_version_x86_{32,64}.hpp

David Holmes - Sun Microsystems David.Holmes at Sun.COM
Sun Feb 22 15:25:08 PST 2009

Looking at the HS sources the tendency has been to separate files rather 
#ifdefs. I know it's not 100% consistent but I'd rather not help swing 
the pendulum back the other way unless there's a really good reason for 
doing so.

David Holmes

Vladimir Kozlov said the following on 02/23/09 06:21:
> Common vm_version_x86.{cpp,hpp} with #ifdef as we did for assembler_x86.?pp
> Vladimir
> Christian Thalinger wrote:
>> On Fri, 2009-02-20 at 11:35 -0500, Paul Hohensee wrote:
>>> Feel free. :)  In general, if you're changing things somewhere, feel 
>>> free to refactor.
>> Great :-)  Should I merge them into a common vm_version_x86.{cpp,hpp}
>> plus specific vm_version_x86_{32,64}.{cpp,hpp} files or just a single
>> vm_version_x86.{cpp,hpp} with #ifdef's?
>> There would be very few #ifdef's but I would prefer the former approach.
>> -- Christian

More information about the hotspot-dev mailing list