Request for review (M): 6808589: Merge vm_version_x86_{32, 64}.{cpp, hpp}

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Mon Feb 23 12:15:01 PST 2009

On Feb 23, 2009, at 11:53 AM, Christian Thalinger wrote:

> On Mon, 2009-02-23 at 10:36 -0800, Tom Rodriguez wrote:
>> Looks good.  Thanks for doing this.  Steve had merged all the
>> important files but there are still a few left like this one.
> No problem.  I will fix the missing ones too if you have some specific
> pointers.

vm_version was easy and it's a file we modify relatively often so it  
was time well spent to my thinking.  The others are mostly harder  
because of things like ABI differences or larger implementation  
differences, like the interpreter and many of the stubs.  I don't see  
any others that are both important and amenable to merging.

> Btw. can someone look at CR 6808665 and tell me if that's still
> used/supported?

It looks like a dead flag to me though I think it could be made to  
work again if anyone cared.  I suspect since no one has complained  
before now that it's dead and could be removed.


> -- Christian

More information about the hotspot-dev mailing list