Request for review (M): 6778669: Patch from Red Hat -- fixes compilation errors
Christian.Thalinger at Sun.COM
Wed Feb 25 07:01:10 PST 2009
On Tue, 2009-02-24 at 21:59 +0100, Christian Thalinger wrote:
> On Tue, 2009-02-24 at 12:37 -0800, Vladimir Kozlov wrote:
> > Changes looks good.
> > Can you just rename (add prefix/suffix) methods defined in MatchRule
> > to avoid the warnings?
> Sure. As Tom also said, I already tried to make some of them virtual
> but it didn't work, so renaming sounds like the better idea. I will do
> that tomorrow.
Here is the final version. I've fixed all method name problems, either
with renaming them or using virtual methods. With SunCC it builds now
with +w -errwarn (like GCC's -Werror).
More information about the hotspot-dev