Request for review (M): 6778669: Patch from Red Hat -- fixes compilation errors
Thomas.Rodriguez at Sun.COM
Wed Feb 25 10:09:26 PST 2009
Have you confirmed that this doesn't change what gets generated by
adlc? In particular making methods virtual could change what gets
called and I don't see any obvious gotchas but I'd like to confirm
that nothing changes in the output.
On Feb 25, 2009, at 7:01 AM, Christian Thalinger wrote:
> On Tue, 2009-02-24 at 21:59 +0100, Christian Thalinger wrote:
>> On Tue, 2009-02-24 at 12:37 -0800, Vladimir Kozlov wrote:
>>> Changes looks good.
>>> Can you just rename (add prefix/suffix) methods defined in MatchRule
>>> to avoid the warnings?
>> Sure. As Tom also said, I already tried to make some of them virtual
>> but it didn't work, so renaming sounds like the better idea. I
>> will do
>> that tomorrow.
> Here is the final version. I've fixed all method name problems,
> with renaming them or using virtual methods. With SunCC it builds now
> with +w -errwarn (like GCC's -Werror).
> -- Christian
More information about the hotspot-dev