Request for review (M): 6778669: Patch from Red Hat -- fixes compilation errors
Thomas.Rodriguez at Sun.COM
Thu Feb 26 08:48:12 PST 2009
On Feb 26, 2009, at 8:02 AM, Christian Thalinger wrote:
> On Wed, 2009-02-25 at 19:37 +0100, Christian Thalinger wrote:
>> On Wed, 2009-02-25 at 10:09 -0800, Tom Rodriguez wrote:
>>> Have you confirmed that this doesn't change what gets generated by
>>> adlc? In particular making methods virtual could change what gets
>>> called and I don't see any obvious gotchas but I'd like to confirm
>>> that nothing changes in the output.
>> I have compared the md5sum's of the generated files on solaris-
>> amd64. I
>> could compare them on other architectures too (except Windows, I
>> know how to build it there).
> Additionally I compared the md5sum's of solaris-i486, solaris-sparc
> solaris-sparcv9 and all were identical. I think it's safe to commit.
> -- Christian
More information about the hotspot-dev