Review request: Zero assembler port
Andrew John Hughes
gnu_andrew at member.fsf.org
Thu Jul 23 07:48:05 PDT 2009
2009/7/16 Gary Benson <gbenson at redhat.com>:
> Christian Thalinger wrote:
>> Gary Benson wrote:
>> > Hi Vikram,
>> > Vikram A wrote:
>> > > Some files ... still show only the copyright header, no source
>> > > code. some have only 4 lines of code. is that what you wanted.
>> > Yes, that's correct. The files are there because the includeDB
>> > lists them, so the build system expects them to be present, but
>> > they don't contain anything. In the IcedTea version of Zero these
>> > files are empty -- they don't even contain the copyright header --
>> > but patch won't create empty files so the webrev ended up
>> > unbuildable.
>> Maybe you should add a comment saying that the file is intentionally
> Good idea, done:
Anyone have any comments on Gary's patch? What more is necessary to
commit this to the hotspot forest?
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the hotspot-dev