Request for review (M): 6812587: Use auxv to determine SPARC hardware features on Solaris
Vladimir.Kozlov at Sun.COM
Tue Mar 10 10:50:20 PDT 2009
Changes look good. Did you verify it on Solaris 9 at least?
My U3 workstation is running Solaris 9.
typo in the comment:
! // Temporary until whave something more accurate
I would remove ", using it" and ", using old legacy code":
! tty->print_cr("getisax(2) supported, using it.");
! tty->print_cr("getisax(2) not supported, using old legacy code.");
Christian Thalinger wrote:
> On Wed, 2009-03-04 at 11:55 -0800, Tom Rodriguez wrote:
>>> That would be the best way. Should I add some dlsym logic?
> Here is a reworked patch that should include all stuff we talked about:
> I am still not completely satisfied with some of the output, like a
> Niagara is detected as an Ultra3, but I don't know if that matters.
> -- Christian
More information about the hotspot-dev