[patch] add missing include in nativeInst_<arch>.cpp

Volker Simonis volker.simonis at gmail.com
Wed Nov 4 07:32:12 PST 2009

Using precompiled headers can hide missing include dependecies -
that's a fact and has already been discussed several times on this
list. Just because building with precompiled headers is *so much*
faster, most developers don't build without precompiled headers and
eventually submit changes which introduce dependencies which are not
reflected in the corresponding includeDB files and only compile by
chance (and precompiled headers:)

I would threfore strongly suggest to run a compilation *WITHOUT*
precompiled headers as preintegration test so prevent such problems in
the future.


PS: there still exist compilers which don't support precomiled headers...

On 11/4/09, Ivan Krylov <Ivan.Krylov at sun.com> wrote:
> Hello Matthias,
>  Can you say why do you want to change default option to precompiled=off ?
> Precompilation helps to build hotspot *a lot* faster.
>  If you need not to use pch just call
>  For debugging purposes you may also want to use HOTSPOT_BUILD_JOBS=1 to
> disable parallel build.
>  Thanks,
>  Ivan
>  Matthias Klose wrote:
> > unsure if this is related to zero/shark, but at least that's in the
> upstream sources for OpenJDK6.
> >
> > These include failures are usually seen, when not using precompiled
> headers (which is a useful thing to track down compiler bugs).
> >
> > attached are two patches to fix the include problem, and one to disable
> the use of precompiled headers setting an envvar. This way release builds
> could be built with and without precompiled headers.
> >
> >  Matthias
> >

More information about the hotspot-dev mailing list