[patch] add missing include in nativeInst_<arch>.cpp
Ivan.Krylov at Sun.COM
Thu Nov 5 11:06:39 PST 2009
>Won't gcc.make still set it to 1 during the build? i.e. isn't
>USE_PRECOMPILED_HEADER= the default anyway?
Apparently no. It is easy enough to try and see yourself.
My understanding of how gmake works is that what is set in command line is passed down to the next makefile in a recursive call via MAKEFLAGS variable.
And we do have recursive call call of make.
However if the value was passed to make via environment variable - it does get overwritten by a makefile (unless -e option is given).
Andrew John Hughes wrote:
> 2009/11/4 Ivan Krylov <Ivan.Krylov at sun.com>:
>> Hello Matthias,
>> Can you say why do you want to change default option to precompiled=off ?
>> Precompilation helps to build hotspot *a lot* faster.
>> If you need not to use pch just call
>> make USE_PRECOMPILED_HEADER=
> Won't gcc.make still set it to 1 during the build? i.e. isn't
> USE_PRECOMPILED_HEADER= the default anyway?
> I presume the other include fix can be pushed without problem?
>> For debugging purposes you may also want to use HOTSPOT_BUILD_JOBS=1 to
>> disable parallel build.
>> Matthias Klose wrote:
>>> unsure if this is related to zero/shark, but at least that's in the
>>> upstream sources for OpenJDK6.
>>> These include failures are usually seen, when not using precompiled
>>> headers (which is a useful thing to track down compiler bugs).
>>> attached are two patches to fix the include problem, and one to disable
>>> the use of precompiled headers setting an envvar. This way release builds
>>> could be built with and without precompiled headers.
More information about the hotspot-dev