Request for reviews (XS): 6902000: use ShouldNotReachHere() for btos/ctos/stos in TemplateInterpreterGenerator::set_short_entry_points
Coleen Phillimore - Sun Microsystems
Coleen.Phillimore at Sun.COM
Wed Nov 18 11:37:36 PST 2009
While you are there, I wonder if you can't just get rid of the btos,
ctos, and stos entries in EntryPoint and save some footprint too. I am
not sure if it's worth it: 2 tables (normal+safepoint) * 256 entries * 8
tos states * sizeof (address). 4096 pointers vs. 2560 pointers. Not
counting the safepoint and other tables of EntryPoints.
On 11/18/09 12:12, Christian Thalinger wrote:
> On Wed, 2009-11-18 at 08:56 -0800, Vladimir Kozlov wrote:
>> Changes are fine but I would place ShouldNotReachHere on separate line.
>> I think it would be more clear this way that it applies to all previous cases.
> You're right. I also missed a break:
> -- Christian
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-dev