Review request: Zero assembler port of HotSpot
Andrew John Hughes
gnu_andrew at member.fsf.org
Wed Sep 23 09:05:04 PDT 2009
2009/9/23 Gary Benson <gbenson at redhat.com>:
> Tom Rodriguez wrote:
>> > > I'm going to look into making it work the way I want. The logic
>> > > is mainly driven through buildtree.make and I recently was
>> > > experimenting with driving that differently so I think I can see
>> > > how to do it. I'll take a stab and get back to you. If I can't
>> > > then linux_zero_zero will have to do.
>> > I'll make a new webrev so you can work on the partially right one.
> I'll mail the list tomorrow (it's end of day here) detailing the
> changes since the last one you reviewed, but you should be able to
> build it using exactly the same variables.
That worked for me, though I guess CORE_BUILD is now redundant.
>> > > Do you insert dummy stub frames to deal with other places that
>> > > use that idiom or are you not using entry points that have that
>> > > pattern?
>> > There's nowhere else in Zero or Shark that creates dummy frames
>> > like this.
>> So I guess this means you never use any of the other compiled stub
>> entry points. Maybe the deopt entry points could be refactored so
>> shark doesn't need a fake frame. Would that make sense?
> It would be possible, though that would require a fair amount of
> conditionalized code in deoptimization.cpp.
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the hotspot-dev