review (S) for 6945219: minor SA fixes

Christian Thalinger Christian.Thalinger at Sun.COM
Tue Apr 20 02:05:33 PDT 2010

On Mon, 2010-04-19 at 16:13 -0700, Tom Rodriguez wrote:
> 6945219: minor SA fixes
> Reviewed-by:
> These are some small SA improvements and fixes that I've collected.
> It includes ignoring an error case when reading core that happens
> regularly when reading 64 bit core files on linux, removing the use of
> show() to avoid deprecation warnings, more fixes to class file
> dumping, improved exception handling/reporting, adding field offsets
> to the information dumped when describing the fields of a class,
> allowing suppression of Assert.that, new commands for the command line
> HSDB and fixes to the handling of history.  Tested by debugging
> crashes with it.

This looks good.  Just a few minor comments.


471                   throw new InternalError("unknown tag:" + cpConstType);

Missing space after ":".


301                   throw new InternalError("unknowon tag: " + cpConstType);


-- Christian

More information about the hotspot-dev mailing list