[patch] fix hotspot build with small SC_ARG_MAX

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Aug 25 09:22:35 PDT 2010

On 8/25/2010 10:11 AM, Christian Thalinger wrote:
> On Wed, 2010-08-25 at 10:00 -0600, Daniel D. Daugherty wrote:
>> Thanks for the reviews Kelly and Christian.
>> Is there a reason to not apply these changes to the solaris and
>> windows versions also? I haven't looked yet, but I figured I
>> would ask...
> Yeah, I also thought about this for Solaris and it should work there as
> on Linux.  Don't know about Windows, though.

Looks like Windows already uses a "make" construct instead of running
into the shell command line limitation:

> $(GENERATED)\sa-jdi.jar: $(AGENT_FILES1:/=\) $(AGENT_FILES2:/=\)

>         @$(COMPILE_JAVAC) -source 1.4 -target 1.4 -classpath 
> urcepath $(AGENT_SRC_DIR) -d $(SA_CLASSDIR) $(AGENT_FILES1:/=\)
>         @$(COMPILE_JAVAC) -source 1.4 -target 1.4 -classpath 
> urcepath $(AGENT_SRC_DIR) -d $(SA_CLASSDIR) $(AGENT_FILES2:/=\)

I also think this is an "nmake" Makefile instead of a GNU Makefile.
I think I'll look at applying the changes to the Solaris Makefile and
leave the Windows stuff alone :-)


More information about the hotspot-dev mailing list