Request for approval: 6929067: Stack guard pages should be removed when thread is detached
aph at redhat.com
Fri Mar 5 01:35:50 PST 2010
On 03/04/2010 10:42 PM, Coleen Phillimore wrote:
> I'm also reviewing this change but I also had the same question about
> iostream. I don't know the history either. We have a similar function
> in os_linux.cpp called find_vma() which uses standard C file io. You
> could rewrite get_stack_bounds() if there's a reason to.
I'll look at ind_vma() and do that.
> The other thing, || *jaxws/jaxws.properties *is checked into a different
> repository (not the hotspot one).
I'm very sorry, that change to jaxws.properties should not have been
included in the webrev. kenai.com fell off the Net yesterday and I
couldn't build without this change.
> Also, I believe you need to add comments from the discussion in the
> emails in the new os_linux.cpp functions, because I for one will lose
> the email connection but it would be useful to preserve the reason for
> this change.
> Lastly, Andrew, do you need a sun employee to check this in? I will do
> this once we resolve the issues above.
I have push access.
More information about the hotspot-dev