Request for approval: 6929067: Stack guard pages should be removed when thread is detached

Andrew Haley aph at
Fri Mar 5 09:59:15 PST 2010

On 03/05/2010 05:25 PM, Coleen Phillimore wrote:
> This looks good to me, there are a couple of questions.  Can you use
> /proc/self/maps instead of getting the tid?

Sure.  I was being defensive because the manpage says:


    This directory refers to the process accessing the /proc
    filesystem, and is identical to the /proc directory named by the
    process ID of the same process.

which I thought meant the PID rather than the TID.  However, the page
is misleading: I just checked and /proc/self refers to the TID.  (Not
that it really matters, as the mappings will mostly be the same

> Also there's a 'my' instead of 'by' in the comments.


By the way, I have a good regression test for this.  Should I submit
that too?


More information about the hotspot-dev mailing list