Request for approval: 6929067: Stack guard pages should be removed when thread is detached
Coleen.Phillimore at Sun.COM
Fri Mar 12 11:35:31 PST 2010
I checked this into the hotspot-rt repository. I thought I made aph the
author but the job came through with my name on it. It also has me as a
reviewer, which I thought that jcheck would flag. I don't know how to
fix this, but I am willing to if someone tells me how.
Andrew Haley wrote:
> On 03/11/2010 09:06 PM, Coleen Phillimore wrote:
>> I've added the test to the changeset and a script to run in our harness.
>> Also in os_linux.cpp, I changed the SYS_gettid call to go through our
>> os::Linux::gettid() because on at least one linux, syscall() returns a
>> long int which gets a compilation warning with %d.
>> open webrev at http://cr.openjdk.java.net/~coleenp/6929067/
>> bug link at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6929067
>> Andrew, please have a look since you're the contributor.
> That's OK, but you don't need SYS_gettid.
> Please look at http://cr.openjdk.java.net/~aph/6929067-jdk7-webrev-4/hotspot.patch
> I changed to "/proc/self/maps", as you requested. I think this is better.
> The copy of my webrev to cr.openjdk.java.net failed for some reason
> I don't understand.
More information about the hotspot-dev