review (S) for 6970683: improvements to hs_err output
vladimir.kozlov at oracle.com
Thu Oct 7 14:03:45 PDT 2010
src/share/vm/utilities/vmError.cpp change comment:
+ STEP(105, "(printing register info)")
+ // registers, top of stack, instructions near pc
src/share/vm/runtime/os.cpp next values are the same why print twice?
+ st->print_cr(INTPTR_FORMAT " is the thread: "
+ INTPTR_FORMAT, addr, thread);
src/share/vm/code/codeCache.cpp closed ")" should be "]" (or it is indication that address in not included?):
+ st->print_cr("Code Cache [" INTPTR_FORMAT ", " INTPTR_FORMAT ", " INTPTR_FORMAT ")",
also why you need to put ' ' around numbers for codecache values? Can you separate them using comma?
src/os_cpu/windows_x86/vm/os_windows_x86.cpp missing #ifdef AMD64 in os::print_register_info() and end of method:
Also why you left Register to memory dump the same? On solaris platforms you print only register name before call to print_location() (I prefer this).
src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp missing "=" after register name in print_register_info().
src/os_cpu/linux_x86/vm/os_linux_x86.cpp print_register_info() should be as in os_solaris_x86.cpp
src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp missing print_register_info() method.
Tom Rodriguez wrote:
> 6970683: improvements to hs_err output
> There are a few things missing from the hs_err dump that would be
> useful. First we don't dump the sparc L and I registers. Second some
> information about the size and contents of the code cache would be
> useful. Third we should dump a larger region around the faulting
> instruction. Additionally the new register to memory mapping output
> can crash which stops us from getting the stack and instructions at
> the faulting pc, so I moved it into it's own section. block_start
> would assert in some cases so I augmented existing logic to just
> return null. I also changed the formatting to remove all the extra
> whitespace and made some of the output more compact and eliminated
> most of the useless whitespace.
More information about the hotspot-dev