review for 7082263: Reflection::resolve_field/field_get/field_set are broken
David.Holmes at oracle.com
Thu Aug 25 21:26:23 PDT 2011
On 26/08/2011 1:35 PM, Tom Rodriguez wrote:
> 1023 lines changed: 0 ins; 1017 del; 6 mod; 10236 unchg
> 7082263: Reflection::resolve_field/field_get/field_set are broken
> The static field mirror changes missed some dead code in reflection.
> Instead of fixing it I'm deleting it. I've deleted all the reflection
> code that's dead. I confirmed that none of these JVM_ entry points
> are referenced by any JDK since 1.5. They also aren't mentioned by
> the jvm.h in the JDK. Tested with JPRT.
Seems the "old reflection" code is partly still the current reflection code! :)
But the deletion looks good. Only thing I'd suggest is to run the jdk
reflection tests in addition to JPRT testing.
More information about the hotspot-dev