review request (S/M): 6962931 move interned strings out of perm gen
christian.thalinger at oracle.com
Thu Feb 17 00:35:31 PST 2011
On Feb 16, 2011, at 10:38 PM, John Coomes wrote:
> Tom Rodriguez (tom.rodriguez at oracle.com) wrote:
>> I had assumed we'd be switching so that strings were always outside
>> perm by default. ScavengeRootsInCode must be != 0 once
>> invokedynamic is enabled by default and since that's definitely
>> going to be enabled in 7 don't we want to turn all this on?
> I discussed this with Tom, so this is mostly for the list ...
> I hadn't done any compiler-specific testing, so wasn't sure if there
> were other parts of the compiler that might be impacted by this
> change. The impact is fairly small, so I'll change
> ScavengeRootsInCode so it defaults to 1.
I think it should be fine to turn it on.
> Other potential reviewers, don't wait for me to update the webrev; I
> have meetings all day so it'll be tonight at the earliest.
>> On Feb 16, 2011, at 10:10 AM, John Coomes wrote:
>>> This moves interned strings from the perm gen into the regular heap.
>>> The code was written by Tom Rodriguez; I've added a minor fix and done
>>> the testing. More info in the webrev:
>>> Thanks for any feedback.
More information about the hotspot-dev