review (M) for 4926272: methodOopDesc::method_from_bcp is unsafe
john.r.rose at oracle.com
Wed Jan 12 16:42:39 PST 2011
On Jan 12, 2011, at 3:17 PM, Coleen Phillimore wrote:
> This is a really nice change.
Exactly my thought.
Tom, thanks for the multiple iterations of extra care. I like the new webrev.
A final thought: I noticed you added methodOopDesc::code_at (with java_code_at), as part of the pattern of making the method argument more explicit everywhere. (Doesn't work everywhere, since sometimes the method is null, but it works lots of places.) You might consider (though it's not necessary) changing some of your use points of Bytecodes::code_at(m,x) to m->code_at(x). One spot I noticed was methodOopDesc::is_accessor.
More information about the hotspot-dev