[PATCH REVIEW]: Include Shark code in the build again
kelly.ohair at oracle.com
Wed Mar 30 09:42:57 PDT 2011
On Mar 30, 2011, at 9:26 AM, Dr Andrew John Hughes wrote:
> This change (arrived at by both myself and Gary Benson separately):
> fixes the issue by adding Shark back into the mix.
> Kelly, can you approve these build changes?
Looks fine to me.
Although overall, I don't understand why someone used so many := assignments.
I usually reserve := for special assignments that require a shell or complex evaluation.
The := forces an expansion of the right side on the spot, so any later changes to the
variables used on the right will have no impact on your variable. In Makefiles, that's
usually what you don't want, but I suppose there are cases where that is expected.
By using := all the time, you have created a specific order dependency on the variables, but
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-dev