[PATCH REVIEW]: Include Shark code in the build again

David Holmes David.Holmes at oracle.com
Thu Mar 31 03:15:35 PDT 2011

Dr Andrew John Hughes said the following on 03/31/11 06:31:
> On 09:42 Wed 30 Mar     , Kelly O'Hair wrote:
>> On Mar 30, 2011, at 9:26 AM, Dr Andrew John Hughes wrote:
>>> This change (arrived at by both myself and Gary Benson separately):
>>> http://cr.openjdk.java.net/~gbenson/zero-shark-fixes-04-1/
>>> fixes the issue by adding Shark back into the mix.
>>> Kelly, can you approve these build changes?
>> Looks fine to me.
> Thanks, so now I just need a HotSpot dev to give it a bug ID and push it through
> their JPRT thing...

7032775 filed ... working on the push


>> ---
>> Although overall, I don't understand why someone used so many := assignments.
>> I usually reserve := for special assignments that require a shell or complex evaluation.
>> The := forces an expansion of the right side on the spot, so any later changes to the
>> variables used on the right will have no impact on your variable. In Makefiles, that's
>> usually what you don't want, but I suppose there are cases where that is expected.
>> By using := all the time, you have created a specific order dependency on the variables, but
>> whatever, ...
> I've never really used := either, and I see your point, but that's not really something to change
> in this changeset :-)
>> -kto

More information about the hotspot-dev mailing list