Request for review (XS): 7109063: JSR 292: fix for 7085860 is incomplete
christian.thalinger at oracle.com
Tue Nov 8 02:22:57 PST 2011
On Nov 7, 2011, at 5:17 PM, Alan Bateman wrote:
> On 07/11/2011 15:45, Christian Thalinger wrote:
>> I'm wondering myself. The other tests' usage of JUnit made me use it in my test too. Anyway, I only use assertEquals which is easy to add to the test itself and then it's self-contained.
>> -- Chris
> Christian and I chatted offline about this with Jon Gibbons and the issue is that this test isn't compiled as a JUnit test because it doesn't specify @run junit. There's a second test (InvokeDynamicPrintArgs.java) with the same issue but that test is excluded from test runs because it's on the problem list (jdk/test/ProblemList.txt).
I fixed InvokeDynamicPrintArgs.java and removed the exclude from ProblemList.txt. Also I did a quick JPRT run of the jdk_lang tests and that looks good. The updated webrev is here:
More information about the hotspot-dev