Request for review: 7069991: Setup make/jprt.properties files for jdk8
kelly.ohair at oracle.com
Wed Nov 23 07:55:11 PST 2011
On Nov 23, 2011, at 7:39 AM, Keith McGuigan wrote:
> On Nov 23, 2011, at 10:17 AM, Kelly O'Hair wrote:
>> FYI... This locks down the repository to only use jdk8, regardless of what the jprt submit -release NNN option says.
>> If this change only went into jdk8 I think it would be fine, but don't these same hotspot sources get
>> integrated into jdk7? Will someone change this to jdk7 when that happens?
> We can tailor the hsxNN repositories to use jdk7 if that's their expected release vehicle. hsx really ought to be jdk8, though. I didn't realize that this setting overrides the -release value passed on the submit line... How would we go about setting a default that is overrideable?
The JPRT default release is jdk7 right now, it is overridable at submit time by using the -release option.
At submit time, JPRT sets jprt.submit.release to whatever the -release setting becomes.
The repository sets it's own specific release value with the jprt.tools.default.release property.
I'm having a hard time envisioning what you would want, making my head hurt.
Give me some suggestions or scenarios how you might want this to work...
> - Keith
More information about the hotspot-dev