Request for review: 7069991: Setup make/ files for jdk8

Keith McGuigan keith.mcguigan at
Wed Nov 23 10:00:27 PST 2011

On Nov 23, 2011, at 12:20 PM, Kelly O'Hair wrote:
> So let me see if I can understand the flow here now...
>  * jprt submit starts up
>  * reads the internal properties of JPRT to see what it thinks the  
> default should be
>  * reads the options supplied to find any explicit release asked for  
> (explicit release does override all settings)
>  * sets jprt.submit.release to the release it thinks it is at this  
> point
>  * THEN it reads the hotspot/make/ file, which should  
> inspect jprt.submit.release to set the right target lists
>  * If no explicit release was set, it checks for  
> So the value of jprt.submit.release is either the explicit release  
> specified by the user, or the default JPRT release
> but you cannot tell the difference.... I think what I should do is  
> only set jprt.submit.release to the explicit release
> from the command line, and leave it empty when there was none.

How about this:

(don't care about the actual names, just placeholders for the logic)

jprt.default => JPRT system default
jprt.repo.default => default release value read out of repo's file
jprt.submit.value => value of -release on the submit command line.

actual release = jprt.submit.value, if non-NULL, otherwise  
jprt.repo.default, if non-NULL, otherwise jprt.default


- Keith

More information about the hotspot-dev mailing list