Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers

Bengt Rutisson bengt.rutisson at
Tue Sep 13 23:33:39 PDT 2011


Thanks for fixing this.

What was it about the template version of method_compartor() that made 
vs2003 generate incorrect optimized code? I just want to make sure I 
don't add more templates with the same issue.

Also, how long will we be supporting vs2003? I was under the impression 
that we had switched to vs2010 even for JDK6. Clearly I was wrong. Does 
that mean that we will keep vs2003 for the duration of JDK6 and thus 
implicitly have that as a build requirement for JDK7 as long as we are 
using the express model?


On 2011-09-14 01:31, Vladimir Kozlov wrote:
> 7090259: Fix hotspot sources to build with old compilers
> Fixed warnings which prevent building VM with old compilers. Used 
> non-template method_comparator() in sort_methods() since vs2003 
> generates incorrect optimized code for it. Added -xwe compilation 
> flag. Tested with 5.7, 5.8 and 5.10 Sun C++.
> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since 
> Tony fixed it already there.
> Thanks,
> Vladimir

More information about the hotspot-dev mailing list