Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers
vladimir.kozlov at oracle.com
Wed Sep 14 09:34:28 PDT 2011
Yes, there was warning:
line 355: Warning: A non-POD object of type "oop" passed as a variable argument
to function "FormatBuffer<256>::FormatBuffer(const char*, ...)".
Try SS11 compiler with your change before you push it.
Jon Masamitsu wrote:
> Where changes like this to explicitly add the cast
> 101 err_msg("Found an inactive reference " PTR_FORMAT " with
> a non-NULL discovered field",
> 102 (oopDesc*)obj));
> because the Solaris compilers issued a warning there?
> I'm wondering because I was just cleaning out some casts
> that I thought were not needed but maybe they are.
> On 9/13/2011 4:31 PM, Vladimir Kozlov wrote:
>> 7090259: Fix hotspot sources to build with old compilers
>> Fixed warnings which prevent building VM with old compilers. Used
>> non-template method_comparator() in sort_methods() since vs2003
>> generates incorrect optimized code for it. Added -xwe compilation
>> flag. Tested with 5.7, 5.8 and 5.10 Sun C++.
>> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since
>> Tony fixed it already there.
More information about the hotspot-dev