Merging BSDPort into HotSpot mainline
landonf at plausible.coop
Wed Sep 14 13:39:14 PDT 2011
On Sep 14, 2011, at 4:21 PM, Tom Rodriguez wrote:
>> ! // HACK: si_code does not work on linux 2.2.12-20!!!
>> ! // HACK: si_code does not work on bsd 2.2.12-20!!!
> I don't think I want to fix things like that. They just make the code diverge.
>> I doubt there is a bsd 2.2.12 kernel :-) Seriously, I suppose si_code does work on BSD?
The s/linux/bsd/ issue aside, si_code is not set on SIGFPE for <= 10.6.
I believe this was fixed in 10.7, but the Apple guys can confirm (tracked by rdar://4428508 ?).
>> + #ifdef __APPLE__
>> + .align 4
>> + #else
>> .align 16
>> + #endif
>> Maybe we should use a ALIGN macro instead.
> Maybe. I'm not sure I even understand the purpose of the change. It seems pretty spurious.
IIRC, Apple's assembler .align directive takes a power of two -- i.e., .align 4^2
More information about the hotspot-dev