review request (XS) - hs23 - set hotspot version & build number
John.Coomes at oracle.com
Fri Sep 16 18:13:08 PDT 2011
Tom Rodriguez (tom.rodriguez at oracle.com) wrote:
> Looks good.
Thanks Tom and others for reviews. After some discussion, I've
updated the webrev (same url,
http://cr.openjdk.java.net/~jcoomes/7091545-hs23/) to set the initial
build number to 01 instead of 00.
The procedure used in previous hs releases when taking a snapshot at
the end of build n was:
1. bump the build number to n
2. add a tag for build number n
3. snapshot build n, generate binaries, run PIT
... build n+1 starts here with HS_BUILD_NUMBER=n ...
With the above process, if we start at 0, the process is consistent
for all the builds. If we start at 1, then that first build is
different from the others - HS_BUILD_NUMBER is already n at the
*start* of the build cycle, and can't be bumped at the end of the
However, a quick poll was unanimous (3/3) that it's confusing to bump
the build number at the end of the cycle; everyone preferred it to be
bumped at the beginning. So the procedure when taking a snapshot at
the end of build n will be:
1. add a tag for build number n
2. snapshot build n, generate binaries and run PIT
3. bump the build number to n+1 (this is not in the snapshot)
... build n+1 starts here with HS_BUILD_NUMBER=n+1 ...
Given this procedure, the build number should start at 1. Whew.
> On Sep 16, 2011, at 2:58 PM, John Coomes wrote:
> > Hotspot is forking to start work on hs23. This is a trivial change to
> > update the version & build numbers.
> > http://cr.openjdk.java.net/~jcoomes/7091545-hs23/
> > -John
More information about the hotspot-dev