RFR (XXS): 7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6
paul.hohensee at oracle.com
Mon Feb 27 13:53:13 PST 2012
Changed jdk7-dev to jdk7u-dev.
On 2/27/12 4:51 PM, Paul Hohensee wrote:
> Looks good. Ship it.
> On 2/26/12 10:57 PM, James Melvin wrote:
>> Hi Stephen,
>> The scope of the work for 7130404 is to...
>> 1) Convert os.arch callsites to use 'x86_64' instead of 'amd64'
>> 2) Add *missing* os.name callsites for Mac OS X
>> I did not originally plan to fixup *existing* os.name callsites.
>> However, your review has inspired me to expand the scope of 7130404 to
>> do just that. I walked the ~300 os.name/os.arch callsites and it turns
>> out that only a couple dozen need fixing up to use .contains() instead
>> of .startsWith(). I've updated the webrevs to reflect this additional
>> work. Might as well get it over now and get on to bigger and better
>> things. :)
>> JPRT hotspot and jdk builds and smoke tests on all platforms
>> Notepad, SwingSet2, SPECjbb2005 on Mac OS X
>> Any final comments would be appreciated.
>> - Jim
>> On 2/22/12 7:39 PM, Stephen Bannasch wrote:
>>> At 6:10 PM -0500 2/22/12, James Melvin wrote:
>>>> Updated to include latest comments...
>>> line 46 still uses: os.startsWith("Mac OS X") instead of
>>> os.contains("OS X")
More information about the hotspot-dev