Patch to fix build breakage with GCC 4.7
robert.ottenhag at oracle.com
Mon Jan 30 02:11:13 PST 2012
Yes, I also agree on the fix (that s/false/NULL/ follows the rest of
each function's fail control logic)
Bengt, please create a bug and do a quick follow up post for proper bug
review. There should be no problem pushing it through hotspot-rt at this
On 01/30/2012 09:01 AM, Bengt Rutisson wrote:
> Hi Deepak and David,
> Looks good to me too. I can commit the fix, but since the changes are
> to runtime code it might be best to push it through the runtime
> repository, right?
> I am not sure about the state of hotspot-rt at the moment. Is it open
> for hs23 bug fixes? Can I go ahead an push there? I can also push it
> through the hotspot-gc repository if that is ok.
> On 2012-01-30 05:55, David Holmes wrote:
>> Hi Deepak,
>> Fix looks good to me. So you have my "approval" as a Reviewer but
>> will need someone else to commit it for you - sorry.
>> On 28/01/2012 7:45 AM, Deepak Bhole wrote:
>>> HotSpot currently fails to build with GCC 4.7 due to 2 points where it
>>> is using boolean rather than NULL. GCC 4.6 treated it as a warning --
>>> 4.7 treats it as an error.
>>> Attached patch fixes the issue and makes it build again.
>>> Please feel free to commit if OK, or let me know if it needs re-work.
Robert Ottenhag | Senior Member of Technical Staff
Phone: +46850630961 | Fax: +46850630911 | Mobile: +46707106161
Oracle Java HotSpot Virtual Machine
ORACLE Sweden | Folkungagatan 122 | SE-116 30 Stockholm
Oracle Svenska AB, Kronborgsgränd 17, S-164 28 KISTA, reg.no. 556254-6746
Oracle is committed to developing practices and products that help protect the environment
More information about the hotspot-dev