Code and Design Feedback request: 7114376: tune system dictionary size
paul.hohensee at oracle.com
Mon Jan 30 06:10:37 PST 2012
Some minor things.
I'd define PRIMEARRAYSIZE, OLDDEFAULTSDSIZE and AVERAGEDEPTHGOAL
as const static int rather than macros. Though I'm not sure anymore whether
the latter can be used as an array size. If not, then I'd define them
Rather than use OLDDEFAULTSDSIZE, I'd use _nof_buckets directly, or set
OLDDEFAULTSDSIZE equal to _nof_buckets.
I'd replace the name "calculate_systemdictionary_size" with
since we know the object is a SystemDictionary.
There's extra blanks in a few places in the definition of
Otherwise looks great.
On 1/29/12 10:12 PM, Karen Kinnear wrote:
> Final review please -
> I reduced this to just add the command-line flag -XX:PredictedLoadedClassCount=#
> and left the dynamic resizing for later.
> webrev: http://cr.openjdk.java.net/~acorn/7114376.02/webrev/
> Manual testing of command-line options, CDS, scimark.
> In parallel: JPRT, nsk, benchmarks
> p.s. the following files did not change between webrev.01 and webrev.02
> On Jan 27, 2012, at 6:13 PM, Karen Kinnear wrote:
>> Dan& David -
>> Thank you both for the detailed reviews.
>> I will make the changes suggested - but I will put the code changes on hold. I think
>> the best approach right now is to just add the command-line flag and then after
>> we get the permanent generation changes, rethink the loaded class cache storage
>> options - and do a whole lot more measurements than I am able to do in this timeframe -
>> even thanks to the help I have had.
>> Details below,
More information about the hotspot-dev