Review request (S): 7140882 (Was: Re: Patch to fix build breakage with GCC 4.7)
ahughes at redhat.com
Mon Jan 30 07:38:51 PST 2012
----- Original Message -----
> Deepak, I saw that you are an "author" for the JDK projects, but not
> the HSX project. Thus, I can't create the changeset as your user.
> Instead I list you as "Contributed-by". That field only supports
> addresses. Here is what the changeset will look like:
> changeset: 3021:f457154eee8b
> tag: tip
> user: brutisso
> date: Mon Jan 30 12:36:49 2012 +0100
> files: src/share/vm/oops/constantPoolOop.cpp
> 7140882: Don't return booleans from methods returning pointers
> Summary: Changed "return false" to "return NULL"
> Reviewed-by: dholmes, rottenha
> Contributed-by: dbhole at redhat.com
That seems wrong. No-one commits to the jdk projects directly, so
what's the point in being a committer/reviewer there?
Both Deepak and I have pushed patches to various repositories before.
Why are our rights being taken away like this?
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
More information about the hotspot-dev