RFR (and sponsor): 7148488: Whitebox tests for the Diagnostic Framework Parser

Bengt Rutisson bengt.rutisson at oracle.com
Wed Mar 21 06:47:25 PDT 2012

Overall this looks good. I chatted with Nils a bit about where the 
wbtestmethods directory should be added in create_obj_files.sh. It is 
not obvious to me that it should be added to the BASE_PATHS. That might 
prevent us from adding tests that require more than a kernel build. Nils 
will look into this a bit.

Otherwise it looks good to me. When we have settled on a solution for 
the path issue in create_obj_files.sh I'm happy to help push this fix.


On 2012-03-21 11:10, Nils Loodin wrote:
> Good idea.
> Refereshed this based on your comments and those of Staffan Larsen.
> New webrev is at http://cr.openjdk.java.net/~nloodin/7148488/webrev.01/
> Need one more reviewer-status reviewer then!
> Regards,
> Nils Loodin
> On Mar 16, 2012, at 16:31 , Mikael Gerdin wrote:
>> Hi,
>> just a small nitpick in parserTests.cpp:
>> 41: const char* lookup_diagnosticArgumentEnum(const char* field_name, oop object)
>> and
>> 52: void fill_in_parser(DCmdParser* parser, oop argument)
>> should probably be static (in the C sense).
>> Otherwise it looks good.
>> /Mikael
>> On 2012-03-15 13:45, Nils Loodin wrote:
>>> Hey all!
>>> Here's an implementation of a nice way of doing parser testing from a
>>> jtreg-test, through the whitebox testing framework.
>>> This patch makes it easy to do parser testing (which will be necessary
>>> if we want to change it with any sort of confidence in the future) and
>>> partly to show off what can be possible to do with the whitebox testing api.
>>> In the added JTREG test, parser testing now works like this from java:
>>> //test that we can parse without exceptions
>>> wb.parseCommandLine("myIntArgument=10", args);
>>> //test that the value get's parsed to what we want
>>> parse("myIntArgument", "10", "myIntArgument=10", args);
>>> //test that illegal command lines gives exception and aren't silently broken
>>> shouldFail("myLongArgument=12m", args); //<-- should fail, doesn't
>>> http://cr.openjdk.java.net/~nloodin/7148488/webrev.00/
>>> Regards,
>>> Nils Loodin

More information about the hotspot-dev mailing list